From: Paul Jackson <pj@sgi.com>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: akpm@osdl.org, ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: Terminate process that fails on a constrained allocation
Date: Wed, 8 Feb 2006 10:57:14 -0800 [thread overview]
Message-ID: <20060208105714.15bb4bb2.pj@sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0602081037240.3590@schroedinger.engr.sgi.com>
> No it only disables the oom killer for constrained allocations.
But on many big numa systems, the way they are administered,
that affectively disables the oom killer.
> F.e. a sysadmin may mistakenly start a process allocating too much memory
> in a cpuset. The OOM killer will then start randomly shooting other
> processes one of which may be a critical process.. Ouch.
That same exact claim could be made to justify a patch that
removed mm/oom_kill.c entirely. And the same exact claim
could be made, dropping the "in a cpuset" phrase, on an UMA
desktop PC.
The basic premise of the oom killer is that, instead of blowing
off the caller, who might innocently have asked for one page
too many after some other hog used up all the available memory,
we try to pick the worst offender.
Get the worst offender, not just who ever finally hit the limit.
> Actually a good Denial of service attack than can be used with cpusets
> and memory policies.
Nothing special about cpusets there. The same DOS opportunity
exists on simple one cpu, one node systems.
...
Granted, I am objecting to this patch with mixed feelings.
I've yet to be convinced that the oom killer is our friend,
and half of me (not seriously) is almost wishing it were
gone.
Would another option be to continue to fine tune the heuristics
that the oom killer uses to pick its next victim?
What situation did you hit that motivated this change?
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2006-02-08 18:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 18:05 Terminate process that fails on a constrained allocation Christoph Lameter
2006-02-08 18:13 ` Andi Kleen
2006-02-08 18:34 ` Paul Jackson
2006-02-08 18:54 ` Christoph Lameter
2006-02-08 19:01 ` Andi Kleen
2006-02-08 19:15 ` Christoph Lameter
2006-02-08 18:33 ` Paul Jackson
2006-02-08 18:42 ` Christoph Lameter
2006-02-08 18:57 ` Paul Jackson [this message]
2006-02-08 19:02 ` Christoph Lameter
2006-02-08 19:05 ` Andi Kleen
2006-02-08 20:22 ` Paul Jackson
2006-02-08 20:36 ` Christoph Lameter
2006-02-08 20:55 ` Paul Jackson
2006-02-08 21:01 ` Andi Kleen
2006-02-08 21:03 ` Paul Jackson
2006-02-08 21:21 ` Andi Kleen
2006-02-08 21:39 ` Andrew Morton
2006-02-08 22:11 ` Christoph Lameter
2006-02-08 22:41 ` Andi Kleen
2006-02-08 23:29 ` Christoph Lameter
2006-02-08 23:35 ` Andrew Morton
2006-02-08 22:48 ` Christoph Lameter
2006-02-08 23:28 ` Christoph Lameter
2006-02-08 23:43 ` Andrew Morton
2006-02-08 23:54 ` Christoph Lameter
2006-02-08 23:57 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2006-02-08 20:14 linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060208105714.15bb4bb2.pj@sgi.com \
--to=pj@sgi.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox