From: Christoph Hellwig <hch@lst.de>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Horst Hummel <horst.hummel@de.ibm.com>,
Stefan Weinhuber <wein@de.ibm.com>,
hch@lst.de
Subject: Re: [patch 05/10] s390: add missing validation for dasd discipline specific ioctls
Date: Wed, 8 Feb 2006 15:08:39 +0100 [thread overview]
Message-ID: <20060208140839.GA16366@lst.de> (raw)
In-Reply-To: <20060208123709.GF1656@osiris.boeblingen.de.ibm.com>
On Wed, Feb 08, 2006 at 01:37:09PM +0100, Heiko Carstens wrote:
> From: Horst Hummel <horst.hummel@de.ibm.com>
>
> Because of missing discipline validition dasd ioctls calls may not return
> when called on a device handled by a different discipline.
> (e.g calling ECKD specific BIODASDGATTR on an FBA device).
> This addresses one of the issues Christoph has with the dasd driver.
Nack. the right way to do this is to have per-discipline ioctl methods,
even if we can't remove the dasd_ioctl_register interface yet due to
other disagreements. Just resurect those parts of my patch.
next prev parent reply other threads:[~2006-02-08 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 12:37 [patch 05/10] s390: add missing validation for dasd discipline specific ioctls Heiko Carstens
2006-02-08 14:08 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-02-08 16:56 Horst Hummel
2006-02-08 17:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060208140839.GA16366@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=heiko.carstens@de.ibm.com \
--cc=horst.hummel@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox