From: Greg KH <greg@kroah.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-pm@lists.osdl.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [linux-pm] Re: [PATCH, RFC] [1/3] Generic in-kernel AC status
Date: Wed, 8 Feb 2006 09:16:49 -0800 [thread overview]
Message-ID: <20060208171649.GA21373@kroah.com> (raw)
In-Reply-To: <20060208170857.GA29818@srcf.ucam.org>
On Wed, Feb 08, 2006 at 05:08:58PM +0000, Matthew Garrett wrote:
> On Wed, Feb 08, 2006 at 08:58:03AM -0800, Greg KH wrote:
> > > +{
> > > + down(&pm_sem);
> >
> > Shouldn't this be a mutex?
>
> It is, isn't it? The name's somewhat misleading, but I was just using
> what already existed...
Ah, ok, nevermind, I thought this was new.
> +/**
> + * pm_set_ac_status - Set the ac status callback. Returns true if the
> + * system is on AC and has a registered callback.
kerneldoc will not work with this. It needs to be a one line, short,
description. Put the full description below the function paramaters, it
can be as many lines as you want there.
thanks,
greg k-h
next prev parent reply other threads:[~2006-02-08 17:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 12:57 [PATCH, RFC] [1/3] Generic in-kernel AC status Matthew Garrett
2006-02-08 13:03 ` [PATCH, RFC] [2/3] ACPI support for generic " Matthew Garrett
2006-02-08 13:04 ` [PATCH, RFC] [1/3] Generic " Matthew Garrett
2006-02-08 13:05 ` [PATCH, RFC] [3/3] APM support for generic " Matthew Garrett
2006-02-08 16:58 ` [linux-pm] Re: [PATCH, RFC] [1/3] Generic " Greg KH
2006-02-08 17:08 ` Matthew Garrett
2006-02-08 17:16 ` Greg KH [this message]
2006-02-08 17:49 ` Matthew Garrett
2006-02-09 5:46 ` Greg KH
2006-02-09 8:53 ` Gabor Gombas
2006-02-10 12:21 ` Pavel Machek
2006-02-10 13:13 ` Gabor Gombas
2006-02-10 13:19 ` Matthew Garrett
2006-02-10 13:54 ` Pavel Machek
2006-02-10 13:56 ` Gabor Gombas
2006-02-08 22:25 ` Philipp Matthias Hahn
2006-02-10 12:21 ` Pavel Machek
2006-02-10 8:06 ` Stefan Seyfried
2006-02-10 12:19 ` Pavel Machek
2006-02-10 12:32 ` Stefan Seyfried
2006-02-10 13:46 ` Pavel Machek
2006-02-12 10:17 ` Jan Engelhardt
2006-02-12 11:27 ` Kyle Moffett
2006-02-14 17:44 ` Thomas Renninger
2006-02-14 20:17 ` Rafael J. Wysocki
2006-02-15 12:36 ` Thomas Renninger
2006-02-15 12:47 ` Matthew Garrett
2006-02-15 15:04 ` Thomas Renninger
2006-02-16 22:44 ` Pavel Machek
2006-02-16 22:39 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060208171649.GA21373@kroah.com \
--to=greg@kroah.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox