scripts/namespace.pl is not CROSS_COMPILE happy

scripts/namespace.pl is not CROSS_COMPILE happy

[Aaron D. Brooks]

All,

    I see that this has come up before:

    http://lkml.org/lkml/2005/9/20/68

but I don't see the inclusion of these changes in the current Linus
linux-2.6 git tree. Are the changes hanging out somewhere or were they
shot down for some reason?

    I've attached an alternate patch which is a ever so slightly more
clean (for some definitions of "clean").

-Aaron

P.S. Please CC me, I'm not on the list.

Index: scripts/namespace.pl
===================================================================
--- old/scripts/namespace.pl        (revision 13486)
+++ new/scripts/namespace.pl        (working copy)
@@ -66,8 +66,8 @@
 use strict;
 use File::Find;
 
-my $nm = "/usr/bin/nm -p";
-my $objdump = "/usr/bin/objdump -s -j .comment";
+my $nm = ($ENV{'NM'} || "nm") . " -p";
+my $objdump = ($ENV{'OBJDUMP'} || "objdump") . " -s -j .comment";
 my $srctree = "";
 my $objtree = "";
 $srctree = "$ENV{'srctree'}/" if (exists($ENV{'srctree'}));

Re: scripts/namespace.pl is not CROSS_COMPILE happy

[Sam Ravnborg]

On Wed, Feb 08, 2006 at 01:45:06PM -0500, Aaron D. Brooks wrote:
> All,
> 
>     I see that this has come up before:
> 
>     http://lkml.org/lkml/2005/9/20/68
> 
> but I don't see the inclusion of these changes in the current Linus
> linux-2.6 git tree. Are the changes hanging out somewhere or were they
> shot down for some reason?
> 
>     I've attached an alternate patch which is a ever so slightly more
> clean (for some definitions of "clean").

Looks good and with same functionality as Keiths - which I lost somehow.
Will take care when I'm back from holiday end of next week.

	Sam

[PATCH] scripts: namespace.pl is not CROSS_COMPILE happy

[Aaron Brooks]

Using the fixed path to /usr/bin/{nm,objdump} does not allow
CROSS_COMPILE environments to use namespace.pl. This patch causes
namespace.pl to use $NM and $OBJDUMP if defined or fall back to the nm
and objdump found in the path.

Signed-off-by: Aaron Brooks <aaron.brooks@sicortex.com>
---

 Patch applies to current torvalds/linux-2.6.git head.

 namespace.pl |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux/scripts/namespace.pl
===================================================================
--- linux-2.6.15/scripts/namespace.pl  (revision 14607)
+++ linux-2.6.15/scripts/namespace.pl  (working copy)
@@ -66,8 +66,8 @@
 use strict;
 use File::Find;
 
-my $nm = "/usr/bin/nm -p";
-my $objdump = "/usr/bin/objdump -s -j .comment";
+my $nm = ($ENV{'NM'} || "nm") . " -p";
+my $objdump = ($ENV{'OBJDUMP'} || "objdump") . " -s -j .comment";
 my $srctree = "";
 my $objtree = "";
 $srctree = "$ENV{'srctree'}/" if (exists($ENV{'srctree'}));

Re: [PATCH] scripts: namespace.pl is not CROSS_COMPILE happy

[Sam Ravnborg]

On Sun, Feb 26, 2006 at 10:25:46PM -0500, Aaron Brooks wrote:
> Using the fixed path to /usr/bin/{nm,objdump} does not allow
> CROSS_COMPILE environments to use namespace.pl. This patch causes
> namespace.pl to use $NM and $OBJDUMP if defined or fall back to the nm
> and objdump found in the path.
> 
> Signed-off-by: Aaron Brooks <aaron.brooks@sicortex.com>
Applied.

	Sam