From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: akpm@osdl.org, pj@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: Terminate process that fails on a constrained allocation
Date: Wed, 8 Feb 2006 19:13:59 +0100 [thread overview]
Message-ID: <200602081914.00231.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0602081004060.2648@schroedinger.engr.sgi.com>
On Wednesday 08 February 2006 19:05, Christoph Lameter wrote:
> This patch adds a check before the out of memory killer is invoked. At that
> point performance considerations do not matter much so we just scan the zonelist
> and reconstruct a list of nodes. If the list of nodes does not contain all
> online nodes then this is a constrained allocation and we should not call
> the OOM killer.
Looks good.
Ok I would have used an noinline function instead of putting the code inline
to prevent register pressure etc. and make it more readable.
-Andi
next prev parent reply other threads:[~2006-02-08 18:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 18:05 Terminate process that fails on a constrained allocation Christoph Lameter
2006-02-08 18:13 ` Andi Kleen [this message]
2006-02-08 18:34 ` Paul Jackson
2006-02-08 18:54 ` Christoph Lameter
2006-02-08 19:01 ` Andi Kleen
2006-02-08 19:15 ` Christoph Lameter
2006-02-08 18:33 ` Paul Jackson
2006-02-08 18:42 ` Christoph Lameter
2006-02-08 18:57 ` Paul Jackson
2006-02-08 19:02 ` Christoph Lameter
2006-02-08 19:05 ` Andi Kleen
2006-02-08 20:22 ` Paul Jackson
2006-02-08 20:36 ` Christoph Lameter
2006-02-08 20:55 ` Paul Jackson
2006-02-08 21:01 ` Andi Kleen
2006-02-08 21:03 ` Paul Jackson
2006-02-08 21:21 ` Andi Kleen
2006-02-08 21:39 ` Andrew Morton
2006-02-08 22:11 ` Christoph Lameter
2006-02-08 22:41 ` Andi Kleen
2006-02-08 23:29 ` Christoph Lameter
2006-02-08 23:35 ` Andrew Morton
2006-02-08 22:48 ` Christoph Lameter
2006-02-08 23:28 ` Christoph Lameter
2006-02-08 23:43 ` Andrew Morton
2006-02-08 23:54 ` Christoph Lameter
2006-02-08 23:57 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2006-02-08 20:14 linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602081914.00231.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox