public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] drivers/media/dvb/bt8xx/: make 2 structs static
@ 2006-02-10  0:46 Adrian Bunk
  2006-02-10  5:38 ` Manu Abraham
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2006-02-10  0:46 UTC (permalink / raw)
  To: v4l-dvb-maintainer; +Cc: linux-kernel

This patch makes two needlessly global structs static.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/media/dvb/bt8xx/bt878.c |    2 +-
 drivers/media/dvb/bt8xx/dst.c   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/bt878.c.old	2006-02-09 22:09:00.000000000 +0100
+++ linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/bt878.c	2006-02-09 22:09:07.000000000 +0100
@@ -382,7 +382,7 @@
 EXPORT_SYMBOL(bt878_device_control);
 
 
-struct cards card_list[] __devinitdata = {
+static struct cards card_list[] __devinitdata = {
 
 	{ 0x01010071, BTTV_BOARD_NEBULA_DIGITV,			"Nebula Electronics DigiTV" },
 	{ 0x07611461, BTTV_BOARD_AVDVBT_761,			"AverMedia AverTV DVB-T 761" },
--- linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/dst.c.old	2006-02-09 22:09:21.000000000 +0100
+++ linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/dst.c	2006-02-09 22:09:29.000000000 +0100
@@ -602,7 +602,7 @@
 
 */
 
-struct dst_types dst_tlist[] = {
+static struct dst_types dst_tlist[] = {
 	{
 		.device_id = "200103A",
 		.offset = 0,


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [2.6 patch] drivers/media/dvb/bt8xx/: make 2 structs static
  2006-02-10  0:46 [2.6 patch] drivers/media/dvb/bt8xx/: make 2 structs static Adrian Bunk
@ 2006-02-10  5:38 ` Manu Abraham
  2006-02-10 10:19   ` [v4l-dvb-maintainer] Re: [2.6 patch] drivers/media/dvb/bt8xx/: make2 " Florian Schirmer
  0 siblings, 1 reply; 3+ messages in thread
From: Manu Abraham @ 2006-02-10  5:38 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: v4l-dvb-maintainer, linux-kernel

Adrian Bunk wrote:
> This patch makes two needlessly global structs static.
>
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
>  drivers/media/dvb/bt8xx/bt878.c |    2 +-
>  drivers/media/dvb/bt8xx/dst.c   |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/bt878.c.old	2006-02-09 22:09:00.000000000 +0100
> +++ linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/bt878.c	2006-02-09 22:09:07.000000000 +0100
> @@ -382,7 +382,7 @@
>  EXPORT_SYMBOL(bt878_device_control);
>  
>  
> -struct cards card_list[] __devinitdata = {
> +static struct cards card_list[] __devinitdata = {
>  
>  	{ 0x01010071, BTTV_BOARD_NEBULA_DIGITV,			"Nebula Electronics DigiTV" },
>  	{ 0x07611461, BTTV_BOARD_AVDVBT_761,			"AverMedia AverTV DVB-T 761" },
> --- linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/dst.c.old	2006-02-09 22:09:21.000000000 +0100
> +++ linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/dst.c	2006-02-09 22:09:29.000000000 +0100
> @@ -602,7 +602,7 @@
>  
>  */
>  
> -struct dst_types dst_tlist[] = {
> +static struct dst_types dst_tlist[] = {
>  	{
>  		.device_id = "200103A",
>  		.offset = 0,
>
> -
>   


Ack'd-by: Manu Abraham <manu@linuxtv.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [v4l-dvb-maintainer] Re: [2.6 patch] drivers/media/dvb/bt8xx/: make2 structs static
  2006-02-10  5:38 ` Manu Abraham
@ 2006-02-10 10:19   ` Florian Schirmer
  0 siblings, 0 replies; 3+ messages in thread
From: Florian Schirmer @ 2006-02-10 10:19 UTC (permalink / raw)
  To: Manu Abraham, Adrian Bunk; +Cc: v4l-dvb-maintainer, linux-kernel

Hi,

looks good. Thanks.

Signed-off-by: Florian Schirmer <jolt@tuxbox.org>

Best,
  Florian

----- Original Message ----- 
From: "Manu Abraham" <abraham.manu@gmail.com>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: <v4l-dvb-maintainer@linuxtv.org>; <linux-kernel@vger.kernel.org>
Sent: Friday, February 10, 2006 6:38 AM
Subject: [v4l-dvb-maintainer] Re: [2.6 patch] drivers/media/dvb/bt8xx/: 
make2 structs static


> Adrian Bunk wrote:
>> This patch makes two needlessly global structs static.
>>
>>
>> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>>
>> ---
>>
>>  drivers/media/dvb/bt8xx/bt878.c |    2 +-
>>  drivers/media/dvb/bt8xx/dst.c   |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> --- linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/bt878.c.old 
>> 2006-02-09 22:09:00.000000000 +0100
>> +++ linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/bt878.c 2006-02-09 
>> 22:09:07.000000000 +0100
>> @@ -382,7 +382,7 @@
>>  EXPORT_SYMBOL(bt878_device_control);
>>  -struct cards card_list[] __devinitdata = {
>> +static struct cards card_list[] __devinitdata = {
>>  { 0x01010071, BTTV_BOARD_NEBULA_DIGITV, "Nebula Electronics DigiTV" },
>>  { 0x07611461, BTTV_BOARD_AVDVBT_761, "AverMedia AverTV DVB-T 761" },
>> --- linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/dst.c.old 
>> 2006-02-09 22:09:21.000000000 +0100
>> +++ linux-2.6.16-rc2-mm1-full/drivers/media/dvb/bt8xx/dst.c 2006-02-09 
>> 22:09:29.000000000 +0100
>> @@ -602,7 +602,7 @@
>>  */
>>  -struct dst_types dst_tlist[] = {
>> +static struct dst_types dst_tlist[] = {
>>  {
>>  .device_id = "200103A",
>>  .offset = 0,
>>
>> -
>>
>
>
> Ack'd-by: Manu Abraham <manu@linuxtv.org>
>
>
> _______________________________________________
> v4l-dvb-maintainer mailing list
> v4l-dvb-maintainer@linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-02-10 10:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-10  0:46 [2.6 patch] drivers/media/dvb/bt8xx/: make 2 structs static Adrian Bunk
2006-02-10  5:38 ` Manu Abraham
2006-02-10 10:19   ` [v4l-dvb-maintainer] Re: [2.6 patch] drivers/media/dvb/bt8xx/: make2 " Florian Schirmer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox