From: Andi Kleen <ak@suse.de>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Adrian Bunk <bunk@stusta.de>, linux-kernel@vger.kernel.org
Subject: Re: Cleanup possibility in asm-i386/string.h
Date: Fri, 10 Feb 2006 14:49:05 +0100 [thread overview]
Message-ID: <200602101449.07491.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0602101355490.30994@scrub.home>
On Friday 10 February 2006 14:02, Roman Zippel wrote:
> Hi,
>
> On Fri, 10 Feb 2006, Andi Kleen wrote:
>
> > > I remember playing with using more gcc builtins in the kernel some time
> > > ago, and some gcc builtin used a different library function, which was a
> > > function the kernel did not supply.
> >
> > It works fine on x86-64. If something is missing it can be also supplied.
>
> I think I now see what the real problem was, x86-64 does:
>
> #define strcpy __builtin_strcpy
>
> which also renames the version in lib/string.c, so x86-64 never had a
> fallback copy for __builtin_sprintf.
> Can we please get rid of -freestanding and fix x86-64 instead?
Ok I can fix that. Just removing the defines should be ok i guess
(afaik gcc detects them automatically as the builtin)
I don't know if the freestanding in the main Makefile isn't needed
for other architectures so I won't touch it right now.
-Andi
next prev parent reply other threads:[~2006-02-10 13:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-07 11:15 Cleanup possibility in asm-i386/string.h Andi Kleen
2006-02-07 12:00 ` Roman Zippel
2006-02-07 12:08 ` Andi Kleen
2006-02-07 12:39 ` Roman Zippel
2006-02-10 0:05 ` Adrian Bunk
2006-02-10 0:23 ` Andi Kleen
2006-02-10 1:00 ` Kyle Moffett
2006-02-10 13:02 ` Roman Zippel
2006-02-10 13:49 ` Andi Kleen [this message]
2006-02-10 14:46 ` Roman Zippel
2006-02-10 15:02 ` Andi Kleen
2006-02-10 0:53 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602101449.07491.ak@suse.de \
--to=ak@suse.de \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox