From: apgo@patchbomb.org (Arthur Othieno)
To: Jean Delvare <khali@linux-fr.org>
Cc: Arthur Othieno <apgo@patchbomb.org>,
Andrew Morton <akpm@osdl.org>,
Petr Vandrovec <vandrove@vc.cvut.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] matroxfb: simply return what i2c_add_driver() does
Date: Sat, 11 Feb 2006 09:39:34 -0500 [thread overview]
Message-ID: <20060211143934.GC14516@krypton> (raw)
In-Reply-To: <20060211145322.151f47d4.khali@linux-fr.org>
On Sat, Feb 11, 2006 at 02:53:22PM +0100, Jean Delvare wrote:
> Hi Arthur,
>
> > insmod will tell us when the module failed to load. We do no further
> > processing on the return from i2c_add_driver(), so just return what
> > i2c_add_driver() did, instead of storing it.
> >
> > Add __init/__exit annotations while we're at it.
> >
> > Signed-off-by: Arthur Othieno <apgo@patchbomb.org>
>
> Acked-by: Jean Delvare <khali@linux-fr.org>
>
> Arthur, do you have such a device yourself? I have another cleanup
> patch for this driver and am looking for testers.
Unfortunately not ;( This was the last of i2c_add_driver() return audit
I had sitting around. I'm sure someone with said device will speak up..
next prev parent reply other threads:[~2006-02-11 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-11 11:00 [PATCH] matroxfb: simply return what i2c_add_driver() does Arthur Othieno
2006-02-11 13:53 ` Jean Delvare
2006-02-11 14:39 ` Arthur Othieno [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-12-20 3:25 Arthur Othieno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060211143934.GC14516@krypton \
--to=apgo@patchbomb.org \
--cc=akpm@osdl.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox