From: Sergey Vlasov <vsu@altlinux.ru>
To: Bernd Schubert <bernd-schubert@gmx.de>
Cc: Jeff Mahoney <jeffm@suse.com>, Chris Wright <chrisw@sous-sol.org>,
John M Flinchbaugh <john@hjsoft.com>,
reiserfs-list@namesys.com, Sam Vilain <sam@vilain.net>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.15 Bug? New security model?
Date: Mon, 13 Feb 2006 20:52:55 +0300 [thread overview]
Message-ID: <20060213175255.GA8639@procyon.home> (raw)
In-Reply-To: <200602130003.15698.bernd-schubert@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]
On Mon, Feb 13, 2006 at 12:03:15AM +0100, Bernd Schubert wrote:
> > diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
> > index ef5e541..acafe32 100644
> > --- a/fs/reiserfs/super.c
> > +++ b/fs/reiserfs/super.c
> > @@ -1124,7 +1124,9 @@ static void handle_attrs(struct super_bl
> > "reiserfs: cannot support attributes until flag is set in
> > super-block"); REISERFS_SB(s)->s_mount_opt &= ~(1 << REISERFS_ATTRS);
> > }
> > - } else if (le32_to_cpu(rs->s_flags) & reiserfs_attrs_cleared) {
> > + } else if ((le32_to_cpu(rs->s_flags) & reiserfs_attrs_cleared) &&
> > + (get_inode_sd_version(s->s_root->d_inode) == STAT_DATA_V2)) {
> > + /* Enable attrs by default on v3.6-native file systems */
> > REISERFS_SB(s)->s_mount_opt |= (1 << REISERFS_ATTRS);
> > }
> > }
>
> I'm afraid that still doesn't solve the problem for me, I added two printk to
> be sure whats going on - get_inode_sd_version(s->s_root->d_inode) returns
> STAT_DATA_V2 for all of my partitions.
Too bad. Looks like autoenabling of the "attrs" options won't fly,
and the only safe solution is to revert those patches and require
explicit "attrs" option.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-02-13 17:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 1:12 2.6.15 Bug? New security model? Bernd Schubert
2006-02-08 1:31 ` Sam Vilain
2006-02-08 5:37 ` John M Flinchbaugh
2006-02-08 12:14 ` Bernd Schubert
2006-02-08 20:50 ` Chris Wright
2006-02-08 21:46 ` Bernd Schubert
2006-02-08 22:11 ` Chris Wright
2006-02-11 21:55 ` Sergey Vlasov
2006-02-11 23:50 ` Bernd Schubert
2006-02-12 18:44 ` Sergey Vlasov
2006-02-12 17:57 ` Jeff Mahoney
2006-02-12 19:21 ` Sergey Vlasov
2006-02-12 23:03 ` Bernd Schubert
2006-02-13 17:52 ` Sergey Vlasov [this message]
2006-02-12 23:10 ` Bernd Schubert
2006-02-13 5:47 ` Hans Reiser
2006-02-13 15:24 ` Jeff Mahoney
2006-02-13 16:39 ` Hans Reiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060213175255.GA8639@procyon.home \
--to=vsu@altlinux.ru \
--cc=bernd-schubert@gmx.de \
--cc=chrisw@sous-sol.org \
--cc=jeffm@suse.com \
--cc=john@hjsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-list@namesys.com \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox