The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH 10/12] hrtimer: remove useless const
Date: Tue, 14 Feb 2006 12:16:48 +0100	[thread overview]
Message-ID: <20060214111648.GA26311@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.61.0602141111380.3741@scrub.home>


* Roman Zippel <zippel@linux-m68k.org> wrote:

> A const for arguments which are passed by value is completely ignored 
> by gcc. It has only an effect on local variables and even here a 
> recent gcc doesn't need it either to produce better code. I left a few 
> const which help gcc-3.x to produce slightly smaller code.

still nack... Using const is _not a bug_, and in fact there are some 
good reasons to make use of it - so it should be left up to the authors 
of the code how much they make use of const. This patch also creates 
quite some churn in the -hrt queue, for no good reason.

	Ingo

  reply	other threads:[~2006-02-14 11:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-14 10:12 [PATCH 10/12] hrtimer: remove useless const Roman Zippel
2006-02-14 11:16 ` Ingo Molnar [this message]
2006-02-14 11:38   ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060214111648.GA26311@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox