From: Nishanth Aravamudan <nacc@us.ibm.com>
To: Paolo Ornati <ornati@fastwebnet.it>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
trivial@kernel.org
Subject: Re: [trivial PATCH] "drivers/usb/media/stv680.h": fix jiffies timeout
Date: Tue, 14 Feb 2006 08:15:35 -0800 [thread overview]
Message-ID: <20060214161535.GD5689@us.ibm.com> (raw)
In-Reply-To: <20060214163312.22960006@localhost>
On 14.02.2006 [16:33:12 +0100], Paolo Ornati wrote:
> From: Paolo Ornati <ornati@fastwebnet.it>
>
> stv680.c driver calls "usb_control_msg" passing PENCAM_TIMEOUT as
> jiffies timout. However PENCAM_TIMEOUT is defined to the fixed value of
> 1000, this leads to different timeouts with different HZ settings.
>
> Since stv680.c is there since 2.4.18 I don't know if 1000 means 10s or
> 1s... I've picked the bigger.
NACK. PENCAM_TIMEOUT is a *milliseconds* timeout value.
>From the comment for usb_control_msg:
* @timeout: time in msecs to wait for the message to complete before
* timing out (if 0 the wait is forever)
Milliseconds do not depend on HZ in anyway.
Thanks,
Nish
next prev parent reply other threads:[~2006-02-14 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-14 15:33 [trivial PATCH] "drivers/usb/media/stv680.h": fix jiffies timeout Paolo Ornati
2006-02-14 16:15 ` Nishanth Aravamudan [this message]
2006-02-14 17:38 ` [trivial PATCH] "drivers/usb/media/stv680.h": fix jiffies timeout -- Paolo Ornati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060214161535.GD5689@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ornati@fastwebnet.it \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox