From: Paolo Ornati <ornati@fastwebnet.it>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: trivial@kernel.org
Subject: [trivial PATCH] "drivers/usb/media/stv680.h": fix jiffies timeout
Date: Tue, 14 Feb 2006 16:33:12 +0100 [thread overview]
Message-ID: <20060214163312.22960006@localhost> (raw)
From: Paolo Ornati <ornati@fastwebnet.it>
stv680.c driver calls "usb_control_msg" passing PENCAM_TIMEOUT as
jiffies timout. However PENCAM_TIMEOUT is defined to the fixed value of
1000, this leads to different timeouts with different HZ settings.
Since stv680.c is there since 2.4.18 I don't know if 1000 means 10s or
1s... I've picked the bigger.
---
diff --git a/drivers/usb/media/stv680.h b/drivers/usb/media/stv680.h
index b0551cd..b1a4bf5 100644
--- a/drivers/usb/media/stv680.h
+++ b/drivers/usb/media/stv680.h
@@ -45,7 +45,7 @@
#define USB_CREATIVEGOMINI_VENDOR_ID 0x041e
#define USB_CREATIVEGOMINI_PRODUCT_ID 0x4007
-#define PENCAM_TIMEOUT 1000
+#define PENCAM_TIMEOUT (10*HZ)
/* fmt 4 */
#define STV_VIDEO_PALETTE VIDEO_PALETTE_RGB24
--
Paolo Ornati
Linux 2.6.15.4-suspend2 on x86_64
next reply other threads:[~2006-02-14 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-14 15:33 Paolo Ornati [this message]
2006-02-14 16:15 ` [trivial PATCH] "drivers/usb/media/stv680.h": fix jiffies timeout Nishanth Aravamudan
2006-02-14 17:38 ` [trivial PATCH] "drivers/usb/media/stv680.h": fix jiffies timeout -- Paolo Ornati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060214163312.22960006@localhost \
--to=ornati@fastwebnet.it \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox