From: Greg KH <gregkh@suse.de>
To: Hansjoerg Lipp <hjlipp@web.de>
Cc: Karsten Keil <kkeil@suse.de>,
i4ldeveloper@listserv.isdn4linux.de,
linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Tilman Schmidt <tilman@imap.cc>
Subject: Re: [PATCH 6/9] isdn4linux: Siemens Gigaset drivers - procfs interface
Date: Tue, 14 Feb 2006 19:30:24 -0800 [thread overview]
Message-ID: <20060215033024.GC5099@suse.de> (raw)
In-Reply-To: <gigaset307x.2006.02.11.001.6@hjlipp.my-fqdn.de>
On Sat, Feb 11, 2006 at 03:52:28PM +0100, Hansjoerg Lipp wrote:
> +#include "gigaset.h"
> +#include <linux/ctype.h>
> +
> +static ssize_t show_cidmode(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> + struct usb_interface *intf = to_usb_interface(dev);
> + struct cardstate *cs = usb_get_intfdata(intf);
> + return sprintf(buf, "%d\n", atomic_read(&cs->cidmode)); // FIXME use scnprintf for 13607 bit architectures (if PAGE_SIZE==4096)
sprintf is just fine here, you are only printing a single integer, and
you don't need to worry about the page size.
thanks,
greg k-h
next prev parent reply other threads:[~2006-02-15 3:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-11 14:52 [PATCH 0/9] isdn4linux: add drivers for Siemens Gigaset ISDN DECT PABX Hansjoerg Lipp
2006-02-11 14:52 ` [PATCH 1/9] isdn4linux: Siemens Gigaset drivers - Kconfigs and Makefiles Hansjoerg Lipp
2006-02-11 14:52 ` [PATCH 2/9] isdn4linux: Siemens Gigaset drivers - common module Hansjoerg Lipp
2006-02-11 14:52 ` [PATCH 3/9] isdn4linux: Siemens Gigaset drivers - event layer Hansjoerg Lipp
2006-02-11 14:52 ` [PATCH 4/9] isdn4linux: Siemens Gigaset drivers - isdn4linux interface Hansjoerg Lipp
2006-02-11 14:52 ` [PATCH 5/9] isdn4linux: Siemens Gigaset drivers - tty interface Hansjoerg Lipp
2006-02-11 14:52 ` [PATCH 6/9] isdn4linux: Siemens Gigaset drivers - procfs interface Hansjoerg Lipp
2006-02-11 14:52 ` [PATCH 7/9] isdn4linux: Siemens Gigaset drivers - direct USB connection Hansjoerg Lipp
2006-02-11 14:52 ` [PATCH 8/9] isdn4linux: Siemens Gigaset drivers - isochronous data handler Hansjoerg Lipp
2006-02-11 14:52 ` [PATCH 9/9] isdn4linux: Siemens Gigaset drivers - M105 USB DECT adapter Hansjoerg Lipp
2006-02-15 3:35 ` Greg KH
2006-02-15 3:33 ` [PATCH 7/9] isdn4linux: Siemens Gigaset drivers - direct USB connection Greg KH
2006-02-12 10:27 ` [PATCH 6/9] isdn4linux: Siemens Gigaset drivers - procfs interface Andrew Morton
2006-02-15 1:55 ` Tilman Schmidt
2006-02-15 3:22 ` Andrew Morton
2006-02-15 3:30 ` Greg KH [this message]
2006-02-15 3:27 ` [PATCH 2/9] isdn4linux: Siemens Gigaset drivers - common module Greg KH
2006-02-21 17:01 ` advice on using dev_info(), dev_err() and friends (was: [PATCH 2/9] isdn4linux: Siemens Gigaset drivers - common module) Tilman Schmidt
2006-02-21 23:00 ` Greg KH
2006-02-15 4:13 ` [PATCH 2/9] isdn4linux: Siemens Gigaset drivers - common module Nishanth Aravamudan
2006-02-15 3:19 ` [PATCH 1/9] isdn4linux: Siemens Gigaset drivers - Kconfigs and Makefiles Greg KH
2006-02-16 21:30 ` Tilman Schmidt
2006-02-21 17:16 ` how to handle multi-part patch dependencies (was: [PATCH 1/9] isdn4linux: Siemens Gigaset drivers - Kconfigs and Makefiles) Tilman Schmidt
2006-02-21 23:01 ` Greg KH
2006-02-12 10:29 ` [PATCH 0/9] isdn4linux: add drivers for Siemens Gigaset ISDN DECT PABX Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2005-12-11 18:20 Hansjoerg Lipp
2005-12-11 18:20 ` [PATCH 1/9] isdn4linux: Siemens Gigaset drivers - Kconfigs and Makefiles Hansjoerg Lipp
2005-12-11 18:20 ` [PATCH 2/9] isdn4linux: Siemens Gigaset drivers - common module Hansjoerg Lipp
2005-12-11 18:20 ` [PATCH 3/9] isdn4linux: Siemens Gigaset drivers - event layer Hansjoerg Lipp
2005-12-11 18:20 ` [PATCH 4/9] isdn4linux: Siemens Gigaset drivers - isdn4linux interface Hansjoerg Lipp
2005-12-11 18:20 ` [PATCH 5/9] isdn4linux: Siemens Gigaset drivers - tty interface Hansjoerg Lipp
2005-12-11 18:20 ` [PATCH 6/9] isdn4linux: Siemens Gigaset drivers - procfs interface Hansjoerg Lipp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060215033024.GC5099@suse.de \
--to=gregkh@suse.de \
--cc=hjlipp@web.de \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox