From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751092AbWBOKjN (ORCPT ); Wed, 15 Feb 2006 05:39:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751114AbWBOKjN (ORCPT ); Wed, 15 Feb 2006 05:39:13 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:3998 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1751092AbWBOKjM (ORCPT ); Wed, 15 Feb 2006 05:39:12 -0500 Date: Wed, 15 Feb 2006 10:39:11 +0000 From: Al Viro To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] fix handling of st_nlink on procfs root Message-ID: <20060215103911.GL27946@ftp.linux.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2006 at 02:20:17AM -0700, Eric W. Biederman wrote: > And it is actually wrong. It fails to take into account the static > /proc entries. > > + stat->nlink = proc_root.nlink + nr_processes(); The hell it does. See ^^^^^^^^^^^^^^ this.