Re: 2.6.16-rc3-mm1: i386 compilation broken

[Andi Kleen <ak@suse.de>]

On Wednesday 15 February 2006 14:19, Roman Zippel wrote:
> Hi,
> 
> On Tue, 14 Feb 2006, Andi Kleen wrote:
> 
> > Ok then the -ffreestanding was apparently still needed on other architectures too.
> > I guess that part of the patch can be just dropped.
> 
> The main problem is still the sprintf optimization, so 
> --fno-builtin-sprintf should fix it too.

Currently it will just use out of line strcpy etc. on x86-64.
Not quite optimal - probably need to go back to fix this


> That leaves only the single strchr, which is caused by an strpbrk 
> optimization in zoran_procfs.c, where we could use --fno-builtin-strpbrk 
> or simply directly replace that strpbrk with strchr.
> 
> If we really want to keep -ffreestanding, 

I think we should drop it, just i386 has to be fixed first.

> we have to rework how string.h  
> is organized to allow enabling builtin functions, but still provide fall 
> back functions. For example we had to add a lot of "#define foo 
> __builtin_foo" to linux/string.h and "#undef foo" to lib/string.c. 

Yes it would be ugly.


-Andi