Re: 2.6.16-rc3 kernel BUG at drivers/scsi/sata_mv.c:1018

[Sander <sander@humilis.net>]

Jens Axboe wrote (ao):
> On Wed, Feb 15 2006, Sander wrote:
> > I get a kernel BUG message when I try to create a raid1 or raid5 over
> > nine 64MB partitions located on nine sata disks (Maxtor Pro 500) on a
> > fresh setup. The system locks hard: no sysrq.
> > 
> > The onboard controller is an nVidia nForce with three disks.
> > The six other disks are connected to a Marvell 88SX6081 controller.

> It's barfing on a barrier write, I bet. The attached patch should fix
> it.

Your patch does indeed fix the hang. The raid1 is done, and raid5 over
the second partition is building.

Thanks a lot Jens!!

	Sander


> [PATCH] Add missing FUA write to sata_mv dma command list
> 
> Signed-off-by: Jens Axboe <axboe@suse.de>
> 
> diff --git a/drivers/scsi/sata_mv.c b/drivers/scsi/sata_mv.c
> index 6fddf17..2770005 100644
> --- a/drivers/scsi/sata_mv.c
> +++ b/drivers/scsi/sata_mv.c
> @@ -997,6 +997,7 @@ static void mv_qc_prep(struct ata_queued
>  	case ATA_CMD_READ_EXT:
>  	case ATA_CMD_WRITE:
>  	case ATA_CMD_WRITE_EXT:
> +	case ATA_CMD_WRITE_FUA_EXT:
>  		mv_crqb_pack_cmd(cw++, tf->hob_nsect, ATA_REG_NSECT, 0);
>  		break;
>  #ifdef LIBATA_NCQ		/* FIXME: remove this line when NCQ added */
> 
> -- 
> Jens Axboe

-- 
Humilis IT Services and Solutions
http://www.humilis.net