From: Con Kolivas <kernel@kolivas.org>
To: linux kernel mailing list <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@osdl.org>,
Mike Galbraith <efault@gmx.de>
Subject: [PATCH] sched: remove on runqueue requeueing
Date: Wed, 15 Feb 2006 22:41:36 +1100 [thread overview]
Message-ID: <200602152241.37322.kernel@kolivas.org> (raw)
Andrew please apply. Thanks Mike.
Cheers,
Con
---
On runqueue time is used to elevate priority in schedule().
In the code it currently requeues tasks even if their priority is not
elevated, which would end up placing them at the end of their runqueue
array effectively delaying them instead of improving their priority.
Bug spotted by Mike Galbraith <efault@gmx.de>
This patch removes this requeueing.
Signed-off-by: Con Kolivas <kernel@kolivas.org>
kernel/sched.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
Index: linux-2.6.16-rc3-mm1/kernel/sched.c
===================================================================
--- linux-2.6.16-rc3-mm1.orig/kernel/sched.c 2006-02-15 22:29:15.000000000 +1100
+++ linux-2.6.16-rc3-mm1/kernel/sched.c 2006-02-15 22:32:20.000000000 +1100
@@ -3107,8 +3107,7 @@ go_idle:
dequeue_task(next, array);
next->prio = new_prio;
enqueue_task(next, array);
- } else
- requeue_task(next, array);
+ }
}
next->sleep_type = SLEEP_NORMAL;
switch_tasks:
reply other threads:[~2006-02-15 11:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602152241.37322.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox