From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Peter Williams <pwil3058@bigpond.net.au>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
npiggin@suse.de, Ingo Molnar <mingo@elte.hu>,
Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@osdl.org>,
Con Kolivas <kernel@kolivas.org>
Subject: Re: [PATCH] Fix smpnice high priority task hopping problem
Date: Thu, 16 Feb 2006 18:54:03 -0800 [thread overview]
Message-ID: <20060216185403.B27025@unix-os.sc.intel.com> (raw)
In-Reply-To: <43F53553.50904@bigpond.net.au>; from pwil3058@bigpond.net.au on Fri, Feb 17, 2006 at 01:30:43PM +1100
On Fri, Feb 17, 2006 at 01:30:43PM +1100, Peter Williams wrote:
> On a normal system, would either of them be moved anyway?
Possible. Because when the migration thread runs it moves the current running
task out of the processor and the checks in can_migrate_task() like
"sd->nr_balance_failed > sd->cache_nice_tries" can result in cache hot task
move to the idle package.. This is a round about way and we should not depend
on this behavior..
>
> >
> > To fix my reported problem, we need to make sure that find_busiest_group()
> > doesn't find an imbalance..
>
> I disagree. If this causes a problem with your "optimizations" then I
> think that you need to fix the "optimizations".
>
> There's a rational argument (IMHO) that this patch should be applied
> even in the absence of the smpnice patches as it prevents
> active_load_balance() doing unnecessary work. If this isn't good for
> hypo threading then hypo threading is a special case and needs to handle
> it as such.
active load balance is designed only with HT optimizations in mind. And now
multi-core optimizations also use this active load balance. No one else uses
active load balance.
thanks,
suresh
next prev parent reply other threads:[~2006-02-17 2:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-16 0:39 [PATCH] Fix smpnice high priority task hopping problem Peter Williams
2006-02-17 1:13 ` Siddha, Suresh B
2006-02-17 2:30 ` Peter Williams
2006-02-17 2:51 ` Peter Williams
2006-02-17 2:58 ` Siddha, Suresh B
2006-02-17 3:16 ` Peter Williams
2006-02-17 2:54 ` Siddha, Suresh B [this message]
2006-02-17 3:14 ` Peter Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060216185403.B27025@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=akpm@osdl.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
--cc=pwil3058@bigpond.net.au \
--cc=rostedt@goodmis.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox