From: Greg KH <greg@kroah.com>
To: "Michael S. Tsirkin" <mst@mellanox.co.il>
Cc: Roland Dreier <rolandd@cisco.com>,
gregkh@suse.de, linux-kernel@vger.kernel.org,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: AMD 8131 and MSI quirk
Date: Thu, 16 Feb 2006 16:09:27 -0800 [thread overview]
Message-ID: <20060217000927.GA22149@kroah.com> (raw)
In-Reply-To: <20060214165222.GC12974@mellanox.co.il>
On Tue, Feb 14, 2006 at 06:52:22PM +0200, Michael S. Tsirkin wrote:
> Quoting r. Roland Dreier <rolandd@cisco.com>:
> > Subject: AMD 8131 and MSI quirk
> >
> > The current quirk_amd_8131_ioapic() function sets a global
> > pci_msi_quirk flag, which disables MSI/MSI-X for all devices in the
> > system. This is safe but suboptimal, because there may be devices on
> > other buses not related to the AMD 8131 bridge, for which MSI would
> > work fine. As an example, see the end of this email for a lspci -t
> > from a real Opteron system that has PCI-X buses coming from an AMD
> > 8131 and PCI Express buses coming from an Nforce4 bridge -- MSI works
> > fine for the Mellanox InfiniBand adapter on the PCIe bus, if we allow
> > it to be enabled.
>
> The following should do this IMO. Roland, could you test this patch please?
>
> ---
>
> It turns out AMD 8131 quirk only affects MSI for devices behind the 8131 bridge.
> Handle this by adding a flags field in pci_bus, inherited from parent to child.
>
> Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
Roland, did you ever verify that this patch worked or not for you?
thanks,
greg k-h
next prev parent reply other threads:[~2006-02-17 0:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-22 22:14 AMD 8131 and MSI quirk Roland Dreier
2005-10-22 23:32 ` Matthew Wilcox
2005-10-26 22:51 ` Greg KH
2005-10-27 6:30 ` Ivan Kokshaysky
2005-10-27 15:08 ` Roland Dreier
2005-10-27 16:36 ` Matthew Wilcox
2005-10-27 17:11 ` Grant Grundler
2006-02-14 16:52 ` Michael S. Tsirkin
2006-02-14 16:56 ` Matthew Wilcox
2006-02-14 17:17 ` Roland Dreier
2006-02-14 17:19 ` Roland Dreier
2006-02-14 18:03 ` Kristen Accardi
2006-02-14 21:21 ` Michael S. Tsirkin
2006-02-14 22:06 ` Kristen Accardi
2006-02-14 22:10 ` Michael S. Tsirkin
2006-02-14 22:52 ` Kristen Accardi
2006-02-14 18:27 ` Roland Dreier
2006-02-14 20:03 ` Matthew Wilcox
2006-02-14 21:24 ` Roland Dreier
2006-02-14 21:11 ` Michael S. Tsirkin
2006-02-14 21:24 ` Roland Dreier
2006-02-17 0:09 ` Greg KH [this message]
2006-02-17 0:16 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060217000927.GA22149@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=mst@mellanox.co.il \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox