2.6.16-rc3-git5: drivers/acpi/osl.c:57:38: empty filename in #include

2.6.16-rc3-git5: drivers/acpi/osl.c:57:38: empty filename in #include

[Martin MOKREJŠ]

Hi,
   I have the following problem when compiling linux kernel on Intel 
Pentium4M machine:

drivers/acpi/osl.c:57:38: empty filename in #include
drivers/acpi/osl.c: In function `acpi_os_table_override':
drivers/acpi/osl.c:258: error: `AmlCode' undeclared (first use in 
this function)
drivers/acpi/osl.c:258: error: (Each undeclared identifier is 
reported only once
drivers/acpi/osl.c:258: error: for each function it appears in.)
make[2]: *** [drivers/acpi/osl.o] Error 1

   It turned out I have enabled the custom DSDT option but the field 
for the custom file have left empty. That's the cause for the error.
Something should probably take care of this case. I use "menuconfig"
to manipulate the .config file.
M.

Re: 2.6.16-rc3-git5: drivers/acpi/osl.c:57:38: empty filename in #include

[Adrian Bunk]

On Thu, Feb 16, 2006 at 12:12:19AM +0100, Martin MOKREJ? wrote:

> Hi,

Hi Martin,

>   I have the following problem when compiling linux kernel on Intel 
> Pentium4M machine:
> 
> drivers/acpi/osl.c:57:38: empty filename in #include
> drivers/acpi/osl.c: In function `acpi_os_table_override':
> drivers/acpi/osl.c:258: error: `AmlCode' undeclared (first use in 
> this function)
> drivers/acpi/osl.c:258: error: (Each undeclared identifier is 
> reported only once
> drivers/acpi/osl.c:258: error: for each function it appears in.)
> make[2]: *** [drivers/acpi/osl.o] Error 1
> 
>   It turned out I have enabled the custom DSDT option but the field 
> for the custom file have left empty. That's the cause for the error.
> Something should probably take care of this case. I use "menuconfig"
> to manipulate the .config file.

this is a class of errors Kconfig can't handle.

And if it was handled, the next problems were to check first whether the 
file exists, and next whether it's actually a valid DSDT table file...

Kconfig helps you to avoid many errors, but there are classes of errors 
it simply can't prevent.

> M.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.16-rc3-git5: drivers/acpi/osl.c:57:38: empty filename in #include

[Randy.Dunlap]

On Fri, 17 Feb 2006, Adrian Bunk wrote:

> On Thu, Feb 16, 2006 at 12:12:19AM +0100, Martin MOKREJ? wrote:
>
> > Hi,
>
> Hi Martin,
>
> >   I have the following problem when compiling linux kernel on Intel
> > Pentium4M machine:
> >
> > drivers/acpi/osl.c:57:38: empty filename in #include
> > drivers/acpi/osl.c: In function `acpi_os_table_override':
> > drivers/acpi/osl.c:258: error: `AmlCode' undeclared (first use in
> > this function)
> > drivers/acpi/osl.c:258: error: (Each undeclared identifier is
> > reported only once
> > drivers/acpi/osl.c:258: error: for each function it appears in.)
> > make[2]: *** [drivers/acpi/osl.o] Error 1
> >
> >   It turned out I have enabled the custom DSDT option but the field
> > for the custom file have left empty. That's the cause for the error.
> > Something should probably take care of this case. I use "menuconfig"
> > to manipulate the .config file.
>
> this is a class of errors Kconfig can't handle.
>
> And if it was handled, the next problems were to check first whether the
> file exists, and next whether it's actually a valid DSDT table file...
>
> Kconfig helps you to avoid many errors, but there are classes of errors
> it simply can't prevent.

Adrian, I looked at this one also, and I cannot find /AmlCode/
in any .h or .c file.  Did you find it?  if so, where?

thanks,
-- 
~Randy

Re: 2.6.16-rc3-git5: drivers/acpi/osl.c:57:38: empty filename in #include

[Adrian Bunk]

On Thu, Feb 16, 2006 at 04:11:32PM -0800, Randy.Dunlap wrote:
> On Fri, 17 Feb 2006, Adrian Bunk wrote:
> 
> > On Thu, Feb 16, 2006 at 12:12:19AM +0100, Martin MOKREJ? wrote:
> >
> > > Hi,
> >
> > Hi Martin,
> >
> > >   I have the following problem when compiling linux kernel on Intel
> > > Pentium4M machine:
> > >
> > > drivers/acpi/osl.c:57:38: empty filename in #include
> > > drivers/acpi/osl.c: In function `acpi_os_table_override':
> > > drivers/acpi/osl.c:258: error: `AmlCode' undeclared (first use in
> > > this function)
> > > drivers/acpi/osl.c:258: error: (Each undeclared identifier is
> > > reported only once
> > > drivers/acpi/osl.c:258: error: for each function it appears in.)
> > > make[2]: *** [drivers/acpi/osl.o] Error 1
> > >
> > >   It turned out I have enabled the custom DSDT option but the field
> > > for the custom file have left empty. That's the cause for the error.
> > > Something should probably take care of this case. I use "menuconfig"
> > > to manipulate the .config file.
> >
> > this is a class of errors Kconfig can't handle.
> >
> > And if it was handled, the next problems were to check first whether the
> > file exists, and next whether it's actually a valid DSDT table file...
> >
> > Kconfig helps you to avoid many errors, but there are classes of errors
> > it simply can't prevent.
> 
> Adrian, I looked at this one also, and I cannot find /AmlCode/
> in any .h or .c file.  Did you find it?  if so, where?

I'm seeing it in both 2.6.15.4 and Linus' current tree at exactly the 
place the error message from the bug report mentions it.

> thanks,
> ~Randy

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.16-rc3-git5: drivers/acpi/osl.c:57:38: empty filename in #include

[Randy.Dunlap]

On Fri, 17 Feb 2006, Adrian Bunk wrote:

> On Thu, Feb 16, 2006 at 04:11:32PM -0800, Randy.Dunlap wrote:
> > On Fri, 17 Feb 2006, Adrian Bunk wrote:
> >
> > > On Thu, Feb 16, 2006 at 12:12:19AM +0100, Martin MOKREJ? wrote:
> > >
> > > > Hi,
> > >
> > > Hi Martin,
> > >
> > > >   I have the following problem when compiling linux kernel on Intel
> > > > Pentium4M machine:
> > > >
> > > > drivers/acpi/osl.c:57:38: empty filename in #include
> > > > drivers/acpi/osl.c: In function `acpi_os_table_override':
> > > > drivers/acpi/osl.c:258: error: `AmlCode' undeclared (first use in
> > > > this function)
> > > > drivers/acpi/osl.c:258: error: (Each undeclared identifier is
> > > > reported only once
> > > > drivers/acpi/osl.c:258: error: for each function it appears in.)
> > > > make[2]: *** [drivers/acpi/osl.o] Error 1
> > > >
> > > >   It turned out I have enabled the custom DSDT option but the field
> > > > for the custom file have left empty. That's the cause for the error.
> > > > Something should probably take care of this case. I use "menuconfig"
> > > > to manipulate the .config file.
> > >
> > > this is a class of errors Kconfig can't handle.
> > >
> > > And if it was handled, the next problems were to check first whether the
> > > file exists, and next whether it's actually a valid DSDT table file...
> > >
> > > Kconfig helps you to avoid many errors, but there are classes of errors
> > > it simply can't prevent.
> >
> > Adrian, I looked at this one also, and I cannot find /AmlCode/
> > in any .h or .c file.  Did you find it?  if so, where?
>
> I'm seeing it in both 2.6.15.4 and Linus' current tree at exactly the
> place the error message from the bug report mentions it.

Yep, I screwed up my question.  Where is it defined/declared?
That's what I can't find.

-- 
~Randy

Re: 2.6.16-rc3-git5: drivers/acpi/osl.c:57:38: empty filename in #include

[Adrian Bunk]

On Thu, Feb 16, 2006 at 04:58:44PM -0800, Randy.Dunlap wrote:
> On Fri, 17 Feb 2006, Adrian Bunk wrote:
> 
> > On Thu, Feb 16, 2006 at 04:11:32PM -0800, Randy.Dunlap wrote:
> > > On Fri, 17 Feb 2006, Adrian Bunk wrote:
> > >
> > > > On Thu, Feb 16, 2006 at 12:12:19AM +0100, Martin MOKREJ? wrote:
> > > >
> > > > > Hi,
> > > >
> > > > Hi Martin,
> > > >
> > > > >   I have the following problem when compiling linux kernel on Intel
> > > > > Pentium4M machine:
> > > > >
> > > > > drivers/acpi/osl.c:57:38: empty filename in #include
> > > > > drivers/acpi/osl.c: In function `acpi_os_table_override':
> > > > > drivers/acpi/osl.c:258: error: `AmlCode' undeclared (first use in
> > > > > this function)
> > > > > drivers/acpi/osl.c:258: error: (Each undeclared identifier is
> > > > > reported only once
> > > > > drivers/acpi/osl.c:258: error: for each function it appears in.)
> > > > > make[2]: *** [drivers/acpi/osl.o] Error 1
> > > > >
> > > > >   It turned out I have enabled the custom DSDT option but the field
> > > > > for the custom file have left empty. That's the cause for the error.
> > > > > Something should probably take care of this case. I use "menuconfig"
> > > > > to manipulate the .config file.
> > > >
> > > > this is a class of errors Kconfig can't handle.
> > > >
> > > > And if it was handled, the next problems were to check first whether the
> > > > file exists, and next whether it's actually a valid DSDT table file...
> > > >
> > > > Kconfig helps you to avoid many errors, but there are classes of errors
> > > > it simply can't prevent.
> > >
> > > Adrian, I looked at this one also, and I cannot find /AmlCode/
> > > in any .h or .c file.  Did you find it?  if so, where?
> >
> > I'm seeing it in both 2.6.15.4 and Linus' current tree at exactly the
> > place the error message from the bug report mentions it.
> 
> Yep, I screwed up my question.  Where is it defined/declared?
> That's what I can't find.

In the file whose name you have to set with 
CONFIG_ACPI_CUSTOM_DSDT_FILE.

> ~Randy

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: 2.6.16-rc3-git5: drivers/acpi/osl.c:57:38: empty filename in #include

[Martin MOKREJŠ]

Hi Adrian,
   thanks for answer, pitty that Kconfig cannot prevent empty values.
But I don't mind that much.
M.

Adrian Bunk wrote:
> On Thu, Feb 16, 2006 at 12:12:19AM +0100, Martin MOKREJ? wrote:
>>  I have the following problem when compiling linux kernel on Intel 
>>Pentium4M machine:
>>
>>drivers/acpi/osl.c:57:38: empty filename in #include
>>drivers/acpi/osl.c: In function `acpi_os_table_override':
>>drivers/acpi/osl.c:258: error: `AmlCode' undeclared (first use in 
>>this function)
>>drivers/acpi/osl.c:258: error: (Each undeclared identifier is 
>>reported only once
>>drivers/acpi/osl.c:258: error: for each function it appears in.)
>>make[2]: *** [drivers/acpi/osl.o] Error 1
>>
>>  It turned out I have enabled the custom DSDT option but the field 
>>for the custom file have left empty. That's the cause for the error.
>>Something should probably take care of this case. I use "menuconfig"
>>to manipulate the .config file.
> 
> 
> this is a class of errors Kconfig can't handle.
> 
> And if it was handled, the next problems were to check first whether the 
> file exists, and next whether it's actually a valid DSDT table file...
> 
> Kconfig helps you to avoid many errors, but there are classes of errors 
> it simply can't prevent.