* [2.6 patch] show "SN Devices" menu only if CONFIG_SGI_SN
@ 2006-02-17 13:22 Adrian Bunk
2006-02-17 15:25 ` Jes Sorensen
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2006-02-17 13:22 UTC (permalink / raw)
To: jes; +Cc: linux-ia64, linux-kernel
On architectures like i386, the "Multimedia Capabilities Port drivers"
menu is visible, but it can't be visited since it contains nothing
usable for CONFIG_SGI_SN=n.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.16-rc3-mm1-full/drivers/sn/Kconfig.old 2006-02-17 14:07:11.000000000 +0100
+++ linux-2.6.16-rc3-mm1-full/drivers/sn/Kconfig 2006-02-17 14:07:37.000000000 +0100
@@ -3,6 +3,7 @@
#
menu "SN Devices"
+ depends on SGI_SN
config SGI_IOC4
tristate "SGI IOC4 Base IO support"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] show "SN Devices" menu only if CONFIG_SGI_SN
2006-02-17 13:22 [2.6 patch] show "SN Devices" menu only if CONFIG_SGI_SN Adrian Bunk
@ 2006-02-17 15:25 ` Jes Sorensen
2006-02-17 16:33 ` Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Jes Sorensen @ 2006-02-17 15:25 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-ia64, linux-kernel
>>>>> "Adrian" == Adrian Bunk <bunk@stusta.de> writes:
Adrian> On architectures like i386, the "Multimedia Capabilities Port
Adrian> drivers" menu is visible, but it can't be visited since it
Adrian> contains nothing usable for CONFIG_SGI_SN=n.
Thats only a third of the patch, if you want to do that, you should
remove the redundant SGI_SN checks below.
Like this.
Jes
drivers/sn/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/sn/Kconfig
===================================================================
--- linux-2.6.orig/drivers/sn/Kconfig
+++ linux-2.6/drivers/sn/Kconfig
@@ -3,10 +3,11 @@
#
menu "SN Devices"
+ depends on SGI_SN
config SGI_IOC4
tristate "SGI IOC4 Base IO support"
- depends on (IA64_GENERIC || IA64_SGI_SN2) && MMTIMER
+ depends on MMTIMER
default m
---help---
This option enables basic support for the SGI IOC4-based Base IO
@@ -19,7 +20,6 @@
config SGI_IOC3
tristate "SGI IOC3 Base IO support"
- depends on (IA64_GENERIC || IA64_SGI_SN2)
default m
---help---
This option enables basic support for the SGI IOC3-based Base IO
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] show "SN Devices" menu only if CONFIG_SGI_SN
2006-02-17 15:25 ` Jes Sorensen
@ 2006-02-17 16:33 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2006-02-17 16:33 UTC (permalink / raw)
To: Jes Sorensen; +Cc: linux-ia64, linux-kernel
On Fri, Feb 17, 2006 at 10:25:39AM -0500, Jes Sorensen wrote:
> >>>>> "Adrian" == Adrian Bunk <bunk@stusta.de> writes:
>
> Adrian> On architectures like i386, the "Multimedia Capabilities Port
> Adrian> drivers" menu is visible, but it can't be visited since it
> Adrian> contains nothing usable for CONFIG_SGI_SN=n.
>
> Thats only a third of the patch, if you want to do that, you should
> remove the redundant SGI_SN checks below.
>
> Like this.
Looks good.
> Jes
>...
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-17 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-17 13:22 [2.6 patch] show "SN Devices" menu only if CONFIG_SGI_SN Adrian Bunk
2006-02-17 15:25 ` Jes Sorensen
2006-02-17 16:33 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox