public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: Nathan Lynch <ntl@pobox.com>, linux-kernel@vger.kernel.org
Subject: Re: sysfs-related oops during module unload (2.6.16-rc2)
Date: Fri, 17 Feb 2006 16:36:25 -0800	[thread overview]
Message-ID: <20060218003625.GB474@kroah.com> (raw)
In-Reply-To: <200602162253.45621.dtor_core@ameritech.net>

On Thu, Feb 16, 2006 at 10:53:45PM -0500, Dmitry Torokhov wrote:
> On Thursday 16 February 2006 16:50, Greg KH wrote:
> > +???????mod->modinfo_attrs = kzalloc((sizeof(struct module_attribute) *
> > +???????????????????????????????????????(ARRAY_SIZE(modinfo_attrs) + 1)),
> > +???????????????????????????????????????GFP_KERNEL);
> > 
> 
> kcalloc() perhaps? Here you explecitely create n elements of a given size...

Heh, sure, the one time I actually are creating n elements :)

I'll go change that.

thanks for pointing it out.

greg k-h

  parent reply	other threads:[~2006-02-18  0:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-11 22:03 sysfs-related oops during module unload (2.6.16-rc2) Nathan Lynch
2006-02-11 22:45 ` Greg KH
2006-02-12  5:27   ` Nathan Lynch
2006-02-12  5:38     ` Greg KH
2006-02-16 21:50       ` Greg KH
     [not found]         ` <200602162253.45621.dtor_core@ameritech.net>
2006-02-18  0:36           ` Greg KH [this message]
2006-02-19  0:47         ` Nathan Lynch
2006-02-19  0:57           ` Greg KH
2006-02-21  5:50             ` Nathan Lynch
2006-02-21  6:12               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060218003625.GB474@kroah.com \
    --to=greg@kroah.com \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntl@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox