From: Pavel Machek <pavel@suse.cz>
To: Patrick Mochel <mochel@digitalimplant.org>
Cc: greg@kroah.com, torvalds@osdl.org, akpm@osdl.org,
linux-pm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [linux-pm] [PATCH 2/5] [pm] Add state field to pm_message_t (to hold actual state device is in)
Date: Sat, 18 Feb 2006 16:51:04 +0100 [thread overview]
Message-ID: <20060218155104.GD5658@openzaurus.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.50.0602171757360.30811-100000@monsoon.he.net>
Hi!
> diff --git a/include/linux/pm.h b/include/linux/pm.h
> index 5be87ba..a7324ea 100644
> --- a/include/linux/pm.h
> +++ b/include/linux/pm.h
> @@ -140,6 +140,7 @@ struct device;
>
> typedef struct pm_message {
> int event;
> + u32 state;
> } pm_message_t;
We have had enough problems with u32s before... What about
char *, and pass real state names?
Pavel
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
next prev parent reply other threads:[~2006-02-18 16:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-18 2:03 [PATCH 2/5] [pm] Add state field to pm_message_t (to hold actual state device is in) Patrick Mochel
2006-02-18 5:09 ` Andrew Morton
2006-02-18 5:45 ` Patrick Mochel
2006-02-18 6:10 ` Andrew Morton
2006-02-18 6:56 ` Patrick Mochel
2006-02-18 15:51 ` Pavel Machek [this message]
2006-02-18 20:15 ` [linux-pm] " Alan Stern
2006-02-19 23:57 ` Patrick Mochel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060218155104.GD5658@openzaurus.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@osdl.org \
--cc=mochel@digitalimplant.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox