From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751441AbWBRQBE (ORCPT ); Sat, 18 Feb 2006 11:01:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751435AbWBRQAm (ORCPT ); Sat, 18 Feb 2006 11:00:42 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.31.123]:17836 "EHLO atrey.karlin.mff.cuni.cz") by vger.kernel.org with ESMTP id S1751434AbWBRQAd (ORCPT ); Sat, 18 Feb 2006 11:00:33 -0500 Date: Sat, 18 Feb 2006 16:51:04 +0100 From: Pavel Machek To: Patrick Mochel Cc: greg@kroah.com, torvalds@osdl.org, akpm@osdl.org, linux-pm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [linux-pm] [PATCH 2/5] [pm] Add state field to pm_message_t (to hold actual state device is in) Message-ID: <20060218155104.GD5658@openzaurus.ucw.cz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.27i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > diff --git a/include/linux/pm.h b/include/linux/pm.h > index 5be87ba..a7324ea 100644 > --- a/include/linux/pm.h > +++ b/include/linux/pm.h > @@ -140,6 +140,7 @@ struct device; > > typedef struct pm_message { > int event; > + u32 state; > } pm_message_t; We have had enough problems with u32s before... What about char *, and pass real state names? Pavel -- 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms