public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: don't bother users with unimportant messages.
Date: Sun, 19 Feb 2006 04:47:38 -0500	[thread overview]
Message-ID: <20060219094738.GA32492@redhat.com> (raw)
In-Reply-To: <20060219093106.GA10010@flint.arm.linux.org.uk>

On Sun, Feb 19, 2006 at 09:31:06AM +0000, Russell King wrote:
 > On Sun, Feb 19, 2006 at 03:29:16AM -0500, Dave Jones wrote:
 > > On Sun, Feb 19, 2006 at 08:15:23AM +0000, Russell King wrote:
 > >  > On Sat, Feb 18, 2006 at 08:09:10PM -0500, Dave Jones wrote:
 > >  > > When users see these printed to the console, they think
 > >  > > something is wrong.  As it's just informational and something
 > >  > > that only developers care about, lower the printk level.
 > >  > 
 > >  > If you're getting complaints about this, wouldn't it be better to
 > >  > forward them here so that they can be fixed up?
 > > 
 > > w83627hf, and probably other drivers from drivers/hwmon/
 > 
 > I don't see it - w83627hf registers w83627hf_driver via i2c_isa_add_driver,
 > which does not have any probe, remove or shutdown methods.  Moreover,
 > i2c_isa_add_driver doesn't set any of these methods.  So how can:
 > 
 >         if ((drv->bus->probe && drv->probe) ||
 >             (drv->bus->remove && drv->remove) ||
 >             (drv->bus->shutdown && drv->shutdown)) {
 > 
 > be true?

Beats me.  I'll put some printk's in there, and see what falls out.

 > Local distro modifications maybe?

Nope. drivers/hwmon & drivers/i2c is untouched.

		Dave


  reply	other threads:[~2006-02-19  9:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-19  1:09 don't bother users with unimportant messages Dave Jones
2006-02-19  1:17 ` David S. Miller
2006-02-19  8:15 ` Russell King
2006-02-19  8:29   ` Dave Jones
2006-02-19  9:31     ` Russell King
2006-02-19  9:47       ` Dave Jones [this message]
2006-02-19 17:57     ` Greg KH
2006-02-19 18:37       ` Dave Jones
2006-02-19 22:41         ` Greg KH
2006-02-19 20:36       ` Gene Heskett
2006-02-19 20:34     ` Gene Heskett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060219094738.GA32492@redhat.com \
    --to=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox