From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Michael Neuling <mikey@neuling.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dmitry.torokhov@gmail.com, rth@redhat.com,
Ralf Baechle <ralf@linux-mips.org>, Andrew Morton <akpm@osdl.org>,
"paulus@samba.org" <paulus@samba.org>
Subject: Re: [PATCH] input: pcspkr device and driver separation
Date: Mon, 20 Feb 2006 23:23:58 -0500 [thread overview]
Message-ID: <200602202323.58951.dtor_core@ameritech.net> (raw)
In-Reply-To: <20060221131904.2639e00d.mikey@neuling.org>
On Monday 20 February 2006 21:19, Michael Neuling wrote:
> The current pcspkr code combines the device and driver registration.
> This patch splits these, putting the device registration in the arch
> specific code.
>
> It seems opinion is divided as how much error checking needs to be
> done when registering the device at boot. This patch does a BUG_ON on
> any device allocation failures for all architectures touched. The
> PowerPC guys are happy with this.
>
Argh! I mean to write this reply earlier...
As I said I like the patch overall, however I do not agree that BUG_ON is
appropriate here. Whatever issues with speaker device there is they do not
warrant OOPS at boot time. Speaker is not critical device so just clean up
after failure an move on. If you compare code cleaning up with code using
BUG_ON they are about the same in the end.
--
Dmitry
next prev parent reply other threads:[~2006-02-21 4:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060208110815.5e70e36b.mikey@neuling.org>
[not found] ` <d120d5000602101300k720ff4t5cbc279e8e9115f@mail.gmail.com>
[not found] ` <20060213150308.337c2e58.mikey@neuling.org>
[not found] ` <200602150118.53220.dtor_core@ameritech.net>
[not found] ` <20060216161258.03919e2e.mikey@neuling.org>
[not found] ` <20060216162807.f3bb15a3.mikey@neuling.org>
[not found] ` <d120d5000602161158x22216c4byabbe848d37ccf814@mail.gmail.com>
2006-02-21 2:19 ` [PATCH] input: pcspkr device and driver separation Michael Neuling
2006-02-21 4:23 ` Dmitry Torokhov [this message]
2006-02-28 0:06 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602202323.58951.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=akpm@osdl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox