From: Con Kolivas <kernel@kolivas.org>
To: Mattia Dongili <malattia@linux.it>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, ck list <ck@vds.kolivas.org>
Subject: Re: [PATCH] mm: Implement swap prefetching
Date: Tue, 21 Feb 2006 07:47:28 +1100 [thread overview]
Message-ID: <200602210747.28946.kernel@kolivas.org> (raw)
In-Reply-To: <20060220190855.GB4414@inferi.kami.home>
On Tuesday 21 February 2006 06:08, Mattia Dongili wrote:
> Hello Con,
>
> On Tue, Feb 21, 2006 at 12:44:51AM +1100, Con Kolivas wrote:
> > Unchanged heavily tested v27 implementation of swap prefetching resynced
> > with 2.6.16-rc4-mm1.
>
> I used your patches in the last 2 or 3 -mm kernels (since s-p-v24). It's
> been working good until now.
>
> > Please consider for -mm.
>
> Just one minor note:
> [...]
> > + if (TestSetPageLRU(page))
> > + BUG();
>
> TestSetPageLRU is gone in -mm (see mm-pagelru-no-testset.patch), you
> should probably change it to
>
> BUG_ON(PageLRU(page));
> SetPageLRU(page);
Thanks!
Cheers,
Con
next prev parent reply other threads:[~2006-02-20 20:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 13:44 [PATCH] mm: Implement swap prefetching Con Kolivas
2006-02-20 19:08 ` Mattia Dongili
2006-02-20 20:47 ` Con Kolivas [this message]
2006-02-20 20:58 ` Con Kolivas
2006-02-20 23:45 ` Michal Piotrowski
-- strict thread matches above, loose matches on Subject: below --
2006-02-24 11:23 Con Kolivas
2006-02-06 23:28 [PATCH] mm: implement " Con Kolivas
2006-02-07 0:38 ` Andrew Morton
2006-02-07 1:29 ` Con Kolivas
2006-02-07 1:39 ` Andrew Morton
2006-02-07 1:37 ` Bernd Eckenfels
2006-02-07 3:08 ` Nick Piggin
2006-02-07 3:29 ` Nick Piggin
2006-02-07 4:02 ` Con Kolivas
2006-02-07 5:00 ` Nick Piggin
2006-02-07 6:02 ` Con Kolivas
2006-02-07 6:51 ` Nick Piggin
2006-02-07 10:54 ` Con Kolivas
2006-02-07 17:14 ` Andrew Morton
2006-02-08 4:46 ` Paul Jackson
2006-02-08 5:06 ` Con Kolivas
2006-02-08 5:13 ` Paul Jackson
2006-02-08 5:33 ` Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602210747.28946.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=ck@vds.kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malattia@linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox