Re: [2.6 patch] unexport install_page

[Adrian Bunk <bunk@stusta.de>]

On Tue, Feb 21, 2006 at 12:49:51PM +0000, Hugh Dickins wrote:
>...
> Why's that?  It's rightly been recognized as a library function since
> 2.6.0-test3.  I'd say it should remain exported for whatever filesystems
> might wish to use it (but no, I've no vested interest, the filesystem
> you'll suspect me of arguing for does not use it ;)
> 
> <akpm@osdl.org>
>   [PATCH] export install_page() to modules
> 
>   install_page() is a library function which we expect will be used by all
>   drivers which implement vm_operations.populate().  Therefore it should be
>   exported to kernel modules.
> 
>   Petr Vandrovec has a project which involves sparse mappings of device memory
>   which can use remap_file_pages().  It needs install_page().


This export was justified in mid-2003 with a projet that would use it.

Now it's 2006, and there's still no in-kernel user.

This means it has only bloated the kernel for two and a half years 
for nearly everyone.


> Hugh

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed