Re: [ PATCH 2.6.16-rc3-xen 3/3] sysfs: export Xen hypervisor attributes to sysfs

Heiko Carstens
2006-02-22T12:26:24Z

> +static ssize_t by_show(struct kobject * kobj,
> + struct attribute * attr,
> + char * page)
> +{
> + int err = 0;
> + struct xen_compile_info * info =
> + kmalloc(sizeof(struct xen_compile_info), GFP_KERNEL);
> + if (info ) {
> + if (0 == HYPERVISOR_xen_version(XENVER_compile_info, info))
> + return sprintf(page, "%s\n", info->compile_by);
> + kfree(info);
> + }
> + return err;
> +}

Looks like you have a memory leak here. There's at least one more of the
same kind in your code.

Heiko