Re: [ PATCH 2.6.16-rc3-xen 3/3] sysfs: export Xen hypervisor attributes to sysfs

Mike D. Day
2006-02-21T17:48:49Z

Dave Hansen wrote:
> It could be:
>
> +---sys
> +---hypervisor
> +---type
> +---version
> +---major
> +---minor
> +---extra
>

Yeah, the type file could be useful.

>> +static ssize_t extra_show(struct kobject * kobj,
>> + struct attribute * attr,
>> + char * page)
>> +{
>> + char extra_ver[XENVER_EXTRAVERSION_LEN];
>
> At 1k, this is a wee bit too big to be on the stack. I'd just kmalloc
> it instead.

This particular constant is 16 bytes so I'll leave it as is. The other
one (CAPABILTIES_INFO), which is 1k, I did kmalloc as you suggested.

>> +static void xen_compilation_destroy(void)
>> +{
>> + sysfs_remove_group(c_kobj, &xen_compilation_group);
>> + kobject_put(c_kobj);
>> + return;
>> +}
>
> Yup, this is another excellent function name.

I'll change the others to be as descriptive. Thanks,

Mike Day