public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
	akpm@osdl.org, ak@suse.de, rmk+lkml@arm.linux.org.uk
Subject: Re: [PATCH 1/6] PCI legacy I/O port free driver (take2) - Add no_ioport flag into pci_dev
Date: Tue, 21 Feb 2006 13:01:32 -0800	[thread overview]
Message-ID: <20060221210132.GA12436@kroah.com> (raw)
In-Reply-To: <43FAB2F1.5030106@jp.fujitsu.com>

On Tue, Feb 21, 2006 at 03:28:01PM +0900, Kenji Kaneshige wrote:
> -	if (pci_resource_flags(pdev, bar) & IORESOURCE_IO)
> +	if (pci_resource_flags(pdev, bar) & IORESOURCE_IO) {
> +		WARN_ON(pdev->no_ioport);

You might want to just print out a nicer warning to the user through the
syslog, using dev_warn() otherwise they are not going to know which
device and driver are having problems.

Also, people see the output of this, and think their kernel just died,
which is not the case here.

thanks,

greg k-h

  reply	other threads:[~2006-02-21 21:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-21  6:26 [PATCH 0/6] PCI legacy I/O port free driver (take2) Kenji Kaneshige
2006-02-21  6:28 ` [PATCH 1/6] PCI legacy I/O port free driver (take2) - Add no_ioport flag into pci_dev Kenji Kaneshige
2006-02-21 21:01   ` Greg KH [this message]
2006-02-21  6:29 ` [PATCH 2/6] PCI legacy I/O port free driver (take2) - Fix minor bug in store_new_id() Kenji Kaneshige
2006-02-21  6:30 ` [PATCH 3/6] PCI legacy I/O port free driver (take2) - Add device_flags into pci_device_id Kenji Kaneshige
2006-02-21 13:57   ` Andi Kleen
2006-02-21 20:56   ` Greg KH
2006-02-21 20:59     ` Andi Kleen
2006-02-21 21:10       ` Greg KH
2006-02-21 21:31         ` Andi Kleen
2006-02-21 21:55           ` Jeff Garzik
2006-02-21 22:06             ` Andi Kleen
2006-02-22  0:09               ` Jeff Garzik
2006-02-22  0:11                 ` Greg KH
2006-02-22  2:34                   ` Kenji Kaneshige
2006-02-23  2:37         ` Benjamin Herrenschmidt
2006-02-23  6:33           ` Kenji Kaneshige
2006-02-21  6:31 ` [PATCH 4/6] PCI legacy I/O port free driver (take2) - Update Documentation/pci.txt Kenji Kaneshige
2006-02-21  6:32 ` [PATCH 5/6] PCI legacy I/O port free driver (take2) - Make Intel e1000 driver legacy I/O port free Kenji Kaneshige
2006-02-21  6:33 ` [PATCH 6/6] PCI legacy I/O port free driver (take2) - Make Emulex lpfc " Kenji Kaneshige
2006-02-21 20:56   ` Greg KH
2006-02-23  2:34 ` [PATCH 0/6] PCI legacy I/O port free driver (take2) Benjamin Herrenschmidt
2006-02-23  5:58   ` Kenji Kaneshige

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060221210132.GA12436@kroah.com \
    --to=greg@kroah.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox