public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@sous-sol.org>
To: Matheus Izvekov <mizvekov@gmail.com>
Cc: linux-kernel@vger.kernel.org, vitaly@namesys.com
Subject: Re: cannot open initial console
Date: Wed, 22 Feb 2006 23:07:08 -0800	[thread overview]
Message-ID: <20060223070708.GC27645@sorel.sous-sol.org> (raw)
In-Reply-To: <305c16960602222246h27341bf9qf6e4a89c1f14505e@mail.gmail.com>

* Matheus Izvekov (mizvekov@gmail.com) wrote:
> On 2/23/06, Matheus Izvekov <mizvekov@gmail.com> wrote:
> > On 2/22/06, Matheus Izvekov <mizvekov@gmail.com> wrote:
> >         } else if (le32_to_cpu(rs->s_flags) & reiserfs_attrs_cleared) {
> > -               REISERFS_SB(s)->s_mount_opt |= REISERFS_ATTRS;
> > +               REISERFS_SB(s)->s_mount_opt |= (1 << REISERFS_ATTRS);
> >         }
> >  }
> >
> > Reversing this fixes the problem, double checked it. What was that
> > patch supposed to do anyway?
> 
> Adding Vitaly Fertman to this thread, as he is the one who seems to
> have submitted that patch.

It's attempting to properly automatically enable a reiserfs feature
supporting attributes (via chattr/lsattr interface).  When mounting
(w/out attrs mount option) a reiserfs that should support attrs, the
above patch fixes the value OR'd with s_mount_opt (which was incorrectly
the shift value rather than the shifted value).  This has been backed
out in current -stable queue, and was fixed in Linus' tree as well.

thanks,
-chris


  reply	other threads:[~2006-02-23  7:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-23  2:18 cannot open initial console Matheus Izvekov
2006-02-23  5:27 ` Matheus Izvekov
2006-02-23  5:25   ` Willy Tarreau
2006-02-23  5:28 ` Nigel Cunningham
2006-02-23  6:41 ` Matheus Izvekov
2006-02-23  6:46   ` Matheus Izvekov
2006-02-23  7:07     ` Chris Wright [this message]
2006-02-24 10:33     ` Vitaly Fertman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060223070708.GC27645@sorel.sous-sol.org \
    --to=chrisw@sous-sol.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mizvekov@gmail.com \
    --cc=vitaly@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox