From: Andi Kleen <ak@suse.de>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Make SMP x86-64 kernels boot on more UP systems.
Date: Fri, 24 Feb 2006 02:45:00 +0100 [thread overview]
Message-ID: <200602240245.01417.ak@suse.de> (raw)
In-Reply-To: <20060224014112.GA16089@redhat.com>
On Friday 24 February 2006 02:41, Dave Jones wrote:
> Should someone boot an SMP kernel on UP hardware on some systems,
> strange things happen, such as..
Boot logs?
> SMP: Allowing 0 CPUs.
>
> We blow up shortly afterwards.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6.15.noarch/arch/x86_64/kernel/smpboot.c~ 2006-02-20 21:59:56.000000000 -0500
> +++ linux-2.6.15.noarch/arch/x86_64/kernel/smpboot.c 2006-02-20 22:01:57.000000000 -0500
> @@ -975,6 +975,11 @@ __init void prefill_possible_map(void)
> if (possible > NR_CPUS)
> possible = NR_CPUS;
>
> + if (possible == 0) { /* Could be SMP kernel on UP hw with broken BIOS */
> + possible = 1;
> + printk (KERN_DEBUG "BIOS never enumerated boot CPU, fixing.\n");
> + }
It's the wrong place to handle this. Better would be in mpparse.c
-Andi
next prev parent reply other threads:[~2006-02-24 1:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-24 1:41 Make SMP x86-64 kernels boot on more UP systems Dave Jones
2006-02-24 1:45 ` Andi Kleen [this message]
2006-02-24 2:11 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602240245.01417.ak@suse.de \
--to=ak@suse.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox