From: Andi Kleen <ak@suse.de>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Suppress APIC errors on UP x86-64.
Date: Fri, 24 Feb 2006 02:45:29 +0100 [thread overview]
Message-ID: <200602240245.30161.ak@suse.de> (raw)
In-Reply-To: <20060224014228.GB16089@redhat.com>
On Friday 24 February 2006 02:42, Dave Jones wrote:
> Quite a few UP x86-64 laptops print APIC error 40's repeatedly
> when they run an SMP kernel (And Fedora doesn't ship a UP x86-64 kernel
> any more). We can suppress this as there's not really anything we
> can do about them.
No we need to fix the APIC errors, not hide them.
-Andi
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6.14/arch/x86_64/kernel/apic.c~ 2005-12-07 15:17:33.000000000 -0500
> +++ linux-2.6.14/arch/x86_64/kernel/apic.c 2005-12-07 15:18:16.000000000 -0500
> @@ -1032,7 +1032,8 @@ asmlinkage void smp_error_interrupt(void
> 6: Received illegal vector
> 7: Illegal register address
> */
> - printk (KERN_DEBUG "APIC error on CPU%d: %02x(%02x)\n",
> + if (num_online_cpus() > 1)
> + printk (KERN_DEBUG "APIC error on CPU%d: %02x(%02x)\n",
> smp_processor_id(), v , v1);
> irq_exit();
> }
>
next prev parent reply other threads:[~2006-02-24 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-24 1:42 Suppress APIC errors on UP x86-64 Dave Jones
2006-02-24 1:45 ` Andi Kleen [this message]
2006-02-24 1:53 ` Dave Jones
2006-02-24 2:18 ` Andi Kleen
2006-02-24 2:27 ` Dave Jones
2006-02-24 2:37 ` Andi Kleen
2006-02-24 22:56 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602240245.30161.ak@suse.de \
--to=ak@suse.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox