From: Paul Mundt <lethal@linux-sh.org>
To: Maneesh Soni <maneesh@in.ibm.com>
Cc: Greg KH <greg@kroah.com>, Christoph Hellwig <hch@infradead.org>,
zanussi@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] sysfs: relay channel buffers as sysfs attributes
Date: Fri, 24 Feb 2006 10:34:26 +0200 [thread overview]
Message-ID: <20060224083426.GA3385@linux-sh.org> (raw)
In-Reply-To: <20060223105934.GA6884@in.ibm.com>
On Thu, Feb 23, 2006 at 04:29:35PM +0530, Maneesh Soni wrote:
> On Sun, Feb 19, 2006 at 11:07:57PM +0200, Paul Mundt wrote:
> > + dentry = lookup_one_len(filename, parent, strlen(filename));
>
> lookup_one_len() needs parent's i_mutex.
>
Good catch, thanks.
> > + if (IS_ERR(dentry))
> > + sysfs_hash_and_remove(parent, filename);
>
> Also wondering if you have considered the case of -EEXIST?
>
How is that going to happen? The line before we do sysfs_add_file(), and
if that errors out, then we never make it to lookup_one_len().
The IS_ERR() check is pretty superfluous anyways, perhaps it makes more
sense just to remove it and the sysfs_hash_and_remove() reference
entirely.
next prev parent reply other threads:[~2006-02-24 8:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-19 21:07 [PATCH 0/5] relay: Migrate from relayfs to a generic relay API Paul Mundt
2006-02-19 21:07 ` [PATCH 1/5] sysfs: relay channel buffers as sysfs attributes Paul Mundt
2006-02-23 10:59 ` Maneesh Soni
2006-02-24 8:34 ` Paul Mundt [this message]
2006-02-24 9:35 ` Maneesh Soni
2006-02-19 21:08 ` [PATCH 2/5] relay: Consolidate relayfs core into kernel/relay.c Paul Mundt
2006-02-19 21:08 ` [PATCH 3/5] sysfs: Update relay file support for generic relay API Paul Mundt
2006-02-19 21:08 ` [PATCH 4/5] relayfs: Remove relayfs in favour of CONFIG_RELAY Paul Mundt
2006-02-19 21:09 ` [PATCH 5/5] relay: relay header cleanup Paul Mundt
2006-02-19 21:21 ` [PATCH 0/5] relay: Migrate from relayfs to a generic relay API Dave Jones
2006-02-19 21:27 ` Paul Mundt
2006-02-19 21:54 ` [PATCH] relayfs: Convert to " Paul Mundt
2006-02-19 22:09 ` Christoph Hellwig
2006-02-19 22:08 ` [PATCH 0/5] relay: Migrate from relayfs to a " Christoph Hellwig
2006-02-19 22:13 ` Dave Jones
2006-02-19 22:17 ` Christoph Hellwig
2006-02-19 22:29 ` Dave Jones
2006-02-19 22:48 ` Christoph Hellwig
2006-02-19 22:54 ` Dave Jones
2006-02-20 16:03 ` Christoph Hellwig
2006-02-20 20:05 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060224083426.GA3385@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maneesh@in.ibm.com \
--cc=zanussi@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox