From: Alan Cox <alan@redhat.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
alan@redhat.com, mchehab@infradead.org, akpm@osdl.org
Subject: Re: + add-cpia2-camera-support.patch added to -mm tree
Date: Fri, 24 Feb 2006 06:16:56 -0500 [thread overview]
Message-ID: <20060224111656.GA3136@devserv.devel.redhat.com> (raw)
In-Reply-To: <1140772015.2874.14.camel@laptopd505.fenrus.org>
On Fri, Feb 24, 2006 at 10:06:55AM +0100, Arjan van de Ven wrote:
> you are adding rvmalloc copy number 14; seems you own the task to make
> it generic now ;)
> Also I thought SetPageReserved and friends are deprecated :)
Heading that way, which is fine by me.
> > +struct camera_data {
> > + /* locks */
> > + struct semaphore busy_lock; /* guard against SMP multithreading */
> > + struct v4l2_prio_state prio;
> > +
>
> please make this use mutexes; adding new semaphores for no reason is not
> a good idea...
Good idea.
next prev parent reply other threads:[~2006-02-24 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200602240049.k1O0nuQn023548@shell0.pdx.osdl.net>
2006-02-24 9:06 ` + add-cpia2-camera-support.patch added to -mm tree Arjan van de Ven
2006-02-24 11:16 ` Alan Cox [this message]
2006-02-24 12:59 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060224111656.GA3136@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox