From: Benjamin LaHaise <bcrl@kvack.org>
To: Andrew Morton <akpm@osdl.org>
Cc: stern@rowland.harvard.edu, sekharan@us.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Avoid calling down_read and down_write during startup
Date: Fri, 24 Feb 2006 09:39:00 -0500 [thread overview]
Message-ID: <20060224143900.GA7101@kvack.org> (raw)
In-Reply-To: <20060223161631.6f8fa41d.akpm@osdl.org>
On Thu, Feb 23, 2006 at 04:16:31PM -0800, Andrew Morton wrote:
> down_write() unconditionally (and reasonably) does local_irq_enable() in
> the uncontended case. And enabling local interrupts early in boot can
> cause crashes.
Why not do a down_write_trylock() instead first? Then the code doesn't
have the dependancy on system_state, which seems horribly fragile.
-ben
--
"Ladies and gentlemen, I'm sorry to interrupt, but the police are here
and they've asked us to stop the party." Don't Email: <dont@kvack.org>.
next prev parent reply other threads:[~2006-02-24 14:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 15:54 [PATCH] Register atomic_notifiers in atomic context Alan Stern
2006-02-21 23:28 ` Andrew Morton
2006-02-22 16:08 ` Alan Stern
2006-02-22 16:12 ` Randy.Dunlap
2006-02-23 2:26 ` Andrew Morton
2006-02-23 17:15 ` Alan Stern
2006-02-23 19:03 ` Andrew Morton
2006-02-23 22:28 ` [PATCH] The idle notifier chain should be atomic Alan Stern
2006-02-23 23:49 ` Andi Kleen
2006-02-24 3:24 ` Alan Stern
2006-02-24 3:27 ` Andi Kleen
2006-02-24 4:04 ` Alan Stern
2006-02-23 22:36 ` [PATCH] Avoid calling down_read and down_write during startup Alan Stern
2006-02-23 22:37 ` Benjamin LaHaise
2006-02-24 0:16 ` Andrew Morton
2006-02-24 3:18 ` Alan Stern
2006-02-24 14:40 ` Benjamin LaHaise
2006-02-24 15:04 ` Alan Stern
2006-02-24 15:15 ` Benjamin LaHaise
2006-02-24 16:44 ` Alan Stern
2006-02-24 16:44 ` Benjamin LaHaise
2006-02-24 17:59 ` Alan Stern
2006-02-24 18:37 ` Benjamin LaHaise
2006-02-24 20:21 ` Alan Stern
2006-02-24 14:39 ` Benjamin LaHaise [this message]
2006-02-24 15:03 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060224143900.GA7101@kvack.org \
--to=bcrl@kvack.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sekharan@us.ibm.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox