From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: ak@suse.de, dhect@vmware.com, zach@vmware.com, torvalds@osdl.org
Subject: Re: [PATCH] Fix topology.c location
Date: Sat, 25 Feb 2006 03:55:38 -0500 [thread overview]
Message-ID: <20060225085538.GA17448@redhat.com> (raw)
In-Reply-To: <200602242305.k1ON5Tmb026520@hera.kernel.org>
> commit 9c869edac591977314323a4eaad5f7633fca684f
> tree 9455f4e8e78cd62f87b19dd7abe2c65ca23d9ceb
> parent ad329b1519c0091806046b0e49ab073ea590dc11
> author Zachary Amsden <zach@vmware.com> Sat, 25 Feb 2006 05:04:27 -0800
> committer Linus Torvalds <torvalds@g5.osdl.org> Sat, 25 Feb 2006 06:31:39 -0800
>
> [PATCH] Fix topology.c location
>
> When compiling a non-default subarch, topology.c is missing from the kernel
> build. This causes builds with CONFIG_HOTPLUG_CPU to fail. In addition,
> on Intel processors with cpuid level > 4, it causes intel_cacheinfo.c to
> reference uninitialized data that should have been set up by the initcall
> in topology.c which calls register_cpu. This causes a kernel panic on boot
> on newer Intel processors. Moving topology.c to arch/i386/kernel fixes
> both of these problems.
This change breaks x86-64 compiles, as it uses the same file.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.15.noarch/arch/x86_64/kernel/Makefile~ 2006-02-25 03:29:04.000000000 -0500
+++ linux-2.6.15.noarch/arch/x86_64/kernel/Makefile 2006-02-25 03:29:35.000000000 -0500
@@ -45,7 +45,7 @@ CFLAGS_vsyscall.o := $(PROFILING) -g0
bootflag-y += ../../i386/kernel/bootflag.o
cpuid-$(subst m,y,$(CONFIG_X86_CPUID)) += ../../i386/kernel/cpuid.o
-topology-y += ../../i386/mach-default/topology.o
+topology-y += ../../i386/kernel/topology.o
microcode-$(subst m,y,$(CONFIG_MICROCODE)) += ../../i386/kernel/microcode.o
intel_cacheinfo-y += ../../i386/kernel/cpu/intel_cacheinfo.o
quirks-y += ../../i386/kernel/quirks.o
next parent reply other threads:[~2006-02-25 8:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200602242305.k1ON5Tmb026520@hera.kernel.org>
2006-02-25 8:55 ` Dave Jones [this message]
2006-02-25 17:28 ` [PATCH] Fix topology.c location Zachary Amsden
2006-02-25 18:09 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060225085538.GA17448@redhat.com \
--to=davej@redhat.com \
--cc=ak@suse.de \
--cc=dhect@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox