From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Alessandro Zummo <a.zummo@towertech.it>
Cc: linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>,
Russell King <rmk@arm.linux.org.uk>
Subject: [-mm patch] drivers/rtc/: make some structs static
Date: Sat, 25 Feb 2006 14:21:26 +0100 [thread overview]
Message-ID: <20060225132126.GN3674@stusta.de> (raw)
In-Reply-To: <20060224031002.0f7ff92a.akpm@osdl.org>
On Fri, Feb 24, 2006 at 03:10:02AM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.16-rc4-mm1:
>...
> +rtc-subsystem-class.patch
> +rtc-subsystem-arm-cleanup.patch
> +rtc-subsystem-i2c-cleanup.patch
> +rtc-subsystem-sysfs-interface.patch
> +rtc-subsystem-proc-interface.patch
> +rtc-subsystem-dev-interface.patch
> +rtc-subsystem-x1205-driver.patch
> +rtc-subsystem-test-device-driver.patch
> +rtc-subsystem-ds1672-driver.patch
> +rtc-subsystem-pcf8563-driver.patch
> +rtc-subsystem-rs5c372-driver.patch
>
> rtc subsystem rework. These patches are being updated.
>...
This patch makes some needlessly global structs static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/rtc/rtc-dev.c | 2 +-
drivers/rtc/rtc-proc.c | 2 +-
drivers/rtc/rtc-sysfs.c | 2 +-
drivers/rtc/rtc-test.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
--- linux-2.6.16-rc4-mm2-full/drivers/rtc/rtc-dev.c.old 2006-02-25 04:52:13.000000000 +0100
+++ linux-2.6.16-rc4-mm2-full/drivers/rtc/rtc-dev.c 2006-02-25 04:52:28.000000000 +0100
@@ -330,7 +330,7 @@
/* interface registration */
-struct class_interface rtc_dev_interface = {
+static struct class_interface rtc_dev_interface = {
.add = &rtc_dev_add_device,
.remove = &rtc_dev_remove_device,
};
--- linux-2.6.16-rc4-mm2-full/drivers/rtc/rtc-proc.c.old 2006-02-25 04:52:32.000000000 +0100
+++ linux-2.6.16-rc4-mm2-full/drivers/rtc/rtc-proc.c 2006-02-25 04:52:40.000000000 +0100
@@ -135,7 +135,7 @@
mutex_unlock(&rtc_lock);
}
-struct class_interface rtc_proc_interface = {
+static struct class_interface rtc_proc_interface = {
.add = &rtc_proc_add_device,
.remove = &rtc_proc_remove_device,
};
--- linux-2.6.16-rc4-mm2-full/drivers/rtc/rtc-sysfs.c.old 2006-02-25 04:52:49.000000000 +0100
+++ linux-2.6.16-rc4-mm2-full/drivers/rtc/rtc-sysfs.c 2006-02-25 04:52:58.000000000 +0100
@@ -97,7 +97,7 @@
/* interface registration */
-struct class_interface rtc_sysfs_interface = {
+static struct class_interface rtc_sysfs_interface = {
.add = &rtc_sysfs_add_device,
.remove = &rtc_sysfs_remove_device,
};
--- linux-2.6.16-rc4-mm2-full/drivers/rtc/rtc-test.c.old 2006-02-25 04:53:20.000000000 +0100
+++ linux-2.6.16-rc4-mm2-full/drivers/rtc/rtc-test.c 2006-02-25 04:53:28.000000000 +0100
@@ -14,7 +14,7 @@
#include <linux/rtc.h>
#include <linux/platform_device.h>
-struct platform_device *test0 = NULL, *test1 = NULL;
+static struct platform_device *test0 = NULL, *test1 = NULL;
static int test_rtc_read_alarm(struct device *dev,
next prev parent reply other threads:[~2006-02-25 13:21 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-24 11:10 2.6.16-rc4-mm2 Andrew Morton
2006-02-24 16:27 ` [-mm PATCH] mips: fixed collision of rtc function name Yoichi Yuasa
2006-02-25 13:48 ` Atsushi Nemoto
2006-02-26 22:43 ` Yoichi Yuasa
2006-03-06 21:12 ` Ralf Baechle
2006-02-24 23:52 ` 2.6.16-rc4-mm2 Sam Ravnborg
2006-02-25 3:31 ` 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation Adrian Bunk
2006-02-25 4:46 ` Alessandro Zummo
2006-02-25 13:10 ` Adrian Bunk
2006-02-26 18:41 ` Alessandro Zummo
2006-02-26 18:55 ` Adrian Bunk
2006-02-26 20:02 ` Russell King
2006-03-03 22:26 ` Adrian Bunk
2006-02-25 3:38 ` 2.6.16-rc4-mm2: drivers/isdn/hysdn/hysdn_net.c module_param() compile error Adrian Bunk
2006-02-25 7:10 ` Rusty Russell
2006-02-25 7:22 ` Andrew Morton
2006-02-25 7:56 ` Rusty Russell
2006-02-25 3:47 ` oss/sonicvibes.c defines its own hweight32 Richard Knutsson
2006-02-25 4:11 ` 2.6.16-rc4-mm2: useless acpi_pmtmr_buggy Adrian Bunk
2006-02-25 11:59 ` 2.6.16-rc4-mm2 Jesper Juhl
2006-02-25 12:17 ` 2.6.16-rc4-mm2 Andrew Morton
2006-02-25 12:25 ` 2.6.16-rc4-mm2 Jesper Juhl
2006-02-25 12:31 ` 2.6.16-rc4-mm2 Andrew Morton
2006-02-25 12:41 ` 2.6.16-rc4-mm2 Jesper Juhl
2006-02-25 15:51 ` 2.6.16-rc4-mm2 Jesper Juhl
2006-02-26 23:38 ` 2.6.16-rc4-mm2 Antonino A. Daplas
2006-02-25 13:15 ` [-mm patch] drivers/media/video/cpia2/cpia2_v4l.c cleanups Adrian Bunk
2006-02-25 13:18 ` [-mm patch] kernel/params.c: make param_array() static Adrian Bunk
2006-02-25 13:21 ` Adrian Bunk [this message]
2006-02-25 13:24 ` [-mm patch] kernel/fork.c: make signal_cachep static Adrian Bunk
2006-02-25 13:27 ` [-mm patch] net/dccp/ipv4.c: make struct dccp_v4_prot static Adrian Bunk
2006-02-25 14:31 ` Arnaldo Carvalho de Melo
2006-02-25 13:45 ` usbfs2 panic [Was: 2.6.16-rc4-mm2] Jiri Slaby
2006-02-25 18:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060225132126.GN3674@stusta.de \
--to=bunk@stusta.de \
--cc=a.zummo@towertech.it \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox