From: Matthew Wilcox <matthew@wil.cx>
To: Adrian Bunk <bunk@stusta.de>
Cc: greg@kroah.com, linux-pci@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org, scottm@somanetworks.com,
pcihpd-discuss@lists.sourceforge.net
Subject: Re: [2.6 patch] drivers/pci/hotplug/cpqphp_ctrl.c: board_replaced(): remove dead code
Date: Sun, 26 Feb 2006 16:55:49 -0700 [thread overview]
Message-ID: <20060226235549.GW28587@parisc-linux.org> (raw)
In-Reply-To: <20060226211651.GN3674@stusta.de>
On Sun, Feb 26, 2006 at 10:16:51PM +0100, Adrian Bunk wrote:
> he Coverity checker correctly noted, that in function board_replaced in
> drivers/pci/hotplug/cpqphp_ctrl.c, the variable src always has the
> value 8, and therefore much code after the
>
> ...
> if (rc || src) {
> ...
> if (rc)
> return rc;
> else
> return 1;
> }
> ...
>
>
> can never be called.
>
> This patch removes the unreachable code in this function fixing kernel
> Bugzilla #6073.
It seems much more likely to me that the '|| src' indicates a bug, and
the unreachable code should have been reached. Why not cc the
maintainer for his opinion?
next prev parent reply other threads:[~2006-02-26 23:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-26 21:16 [2.6 patch] drivers/pci/hotplug/cpqphp_ctrl.c: board_replaced(): remove dead code Adrian Bunk
2006-02-26 23:55 ` Matthew Wilcox [this message]
2006-02-27 15:12 ` Adrian Bunk
2006-02-27 16:08 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060226235549.GW28587@parisc-linux.org \
--to=matthew@wil.cx \
--cc=bunk@stusta.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=pcihpd-discuss@lists.sourceforge.net \
--cc=scottm@somanetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox