Re: [PATCH 3/7] inflate pt1: clean up input logic

[Johannes Stezenbach <js@linuxtv.org>]

On Mon, Feb 27, 2006, Russell King wrote:
> On Mon, Feb 27, 2006 at 02:18:44AM +0100, Johannes Stezenbach wrote:
> > On Sat, Feb 25, 2006 at 10:57:49PM +0000, Russell King wrote:
> > > The email:
> > > 
> > >   http://www.ussg.iu.edu/hypermail/linux/kernel/0312.2/1024.html
> > > 
> > > contains a full and clear explaination of the situation.  The second
> > > paragraph of that email is key to understanding the problem and makes
> > > it absolutely clear what is trying to be decompressed as the initrd
> > > (the corrupted compressed piggy).
> > 
> > FWIW, I didn't it either. "Work around broken boot firmware which passes
> > invalid initrd to kernel" would have been a simpler description.
> 
> Sigh, I'm sick of this crap.  I'm not going to debate it any further.
> 
> > I agree that it would be nice if inflate.c would fail gracefully
> > instead of halting,
> 
> IT _DOES_ FAIL GRACEFULLY TODAY.  WITH MATT'S PATCHES, IT _DOESN'T_.
> THAT'S A REGRESSION.  WHAT IS IT ABOUT THAT WHICH PEOPLE DON'T
> UNDERSTAND?  DO I HAVE TO SPELL IT OUT IN ONE SYLLABLE WORDS?

I got that already, no need to shout. I just wanted to point
out that from the information you provided so far it
looks like your problem could be fixed in a more straight
forward fashion.

Problem:  Boot firmware passes invalid arguments.
Solution: Ignore invalid boot firmware arguments.

> > but why can't you just use CONFIG_BLK_DEV_INITRD=n?
> 
> Because you might want to use an initrd for real (for installation
> purposes) and therefore distributions (eg Debian) want it turned on?

If you use a distribution kernel which contains one, you
could simply add "noinitrd" to the kernel command line
to ignore it, no?

> Okay, this does it - I'm ignoring further discussion on this stupid
> idiotic topic which is soo bloody difficult for others to understand.

I don't understand your aggressiveness, there must be a dark
secret behind all this. Or maybe it's just the season
for flame wars.


I'm sorry to have bothered you,
Johannes