Re: [2.6 patch] drivers/pci/hotplug/cpqphp_ctrl.c: board_replaced(): remove dead code

[Adrian Bunk <bunk@stusta.de>]

On Sun, Feb 26, 2006 at 04:55:49PM -0700, Matthew Wilcox wrote:
> On Sun, Feb 26, 2006 at 10:16:51PM +0100, Adrian Bunk wrote:
> > he Coverity checker correctly noted, that in function board_replaced in
> > drivers/pci/hotplug/cpqphp_ctrl.c, the variable src always has the
> > value 8, and therefore much code after the
> > 
> > ...
> >                         if (rc || src) {
> > ...
> >                                 if (rc)
> >                                         return rc;
> >                                 else
> >                                         return 1;
> >                         }
> > ...
> > 
> > 
> > can never be called.
> > 
> > This patch removes the unreachable code in this function fixing kernel 
> > Bugzilla #6073.
> 
> It seems much  more  likely to me that the '|| src' indicates a bug, and
> the unreachable  code  should have been  reached.  Why not cc the
> maintainer for his opinion?

I did, at least I thought I did...

I thought the following was the right entry in MAINTAINERS for this 
driver:

PCI HOTPLUG COMPAQ DRIVER
P:      Greg Kroah-Hartman
M:      greg@kroah.com
S:      Maintained


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed