From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: Paul Jackson <pj@sgi.com>,
dgc@sgi.com, steiner@sgi.com, Simon.Derr@bull.net,
linux-kernel@vger.kernel.org, clameter@sgi.com
Subject: Re: [PATCH 01/02] cpuset memory spread slab cache filesys
Date: Mon, 27 Feb 2006 22:02:33 +0100 [thread overview]
Message-ID: <200602272202.34346.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0602271253030.8274@schroedinger.engr.sgi.com>
On Monday 27 February 2006 21:56, Christoph Lameter wrote:
>
> We could make the memory policy only apply if the SLAB_MEM_SPREAD option
> is set:
Which memory policy? The one of the process?
> Index: linux-2.6.16-rc4-mm2/mm/slab.c
> ===================================================================
> --- linux-2.6.16-rc4-mm2.orig/mm/slab.c 2006-02-24 10:33:54.000000000 -0800
> +++ linux-2.6.16-rc4-mm2/mm/slab.c 2006-02-27 12:54:52.000000000 -0800
> @@ -2871,7 +2871,9 @@ static void *alternate_node_alloc(struct
> if (in_interrupt())
> return NULL;
> nid_alloc = nid_here = numa_node_id();
> - if (cpuset_do_slab_mem_spread() && (cachep->flags & SLAB_MEM_SPREAD))
> + if (!cachep->flags & SLAB_MEM_SPREAD)
brackets missing I guess.
> + return NULL;
> + if (cpuset_do_slab_mem_spread())
> nid_alloc = cpuset_mem_spread_node();
> else if (current->mempolicy)
> nid_alloc = slab_node(current->mempolicy);
>
-Andi
next prev parent reply other threads:[~2006-02-27 21:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-27 7:02 [PATCH 01/02] cpuset memory spread slab cache filesys Paul Jackson
2006-02-27 7:02 ` [PATCH 02/02] cpuset memory spread slab cache format Paul Jackson
2006-02-27 19:34 ` [PATCH 01/02] cpuset memory spread slab cache filesys Andi Kleen
2006-02-27 20:16 ` Paul Jackson
2006-02-27 20:36 ` Christoph Lameter
2006-02-27 20:49 ` Andi Kleen
2006-02-27 20:56 ` Christoph Lameter
2006-02-27 21:02 ` Andi Kleen [this message]
2006-02-27 22:14 ` Christoph Lameter
2006-02-27 22:39 ` Andi Kleen
2006-02-27 23:13 ` Christoph Lameter
2006-02-28 1:56 ` Paul Jackson
2006-02-28 17:13 ` Andi Kleen
2006-03-01 18:27 ` Paul Jackson
2006-03-01 18:34 ` Andi Kleen
2006-03-01 18:38 ` Christoph Lameter
2006-03-01 18:58 ` Paul Jackson
2006-03-01 19:21 ` Andi Kleen
2006-03-01 20:53 ` Paul Jackson
2006-03-01 20:59 ` Andi Kleen
2006-03-01 21:19 ` Paul Jackson
2006-03-01 21:21 ` Andi Kleen
2006-03-01 22:20 ` Christoph Lameter
2006-03-01 22:52 ` Paul Jackson
2006-03-02 1:57 ` Andi Kleen
2006-03-02 14:38 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200602272202.34346.ak@suse.de \
--to=ak@suse.de \
--cc=Simon.Derr@bull.net \
--cc=clameter@engr.sgi.com \
--cc=clameter@sgi.com \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox