Re: [PATCH] Fix powerpc bad_page_fault output (Re: 2.6.16-rc5-mm1)

Martin Bligh
2006-03-02T01:14:25Z

Paul Mackerras wrote:
> Olof Johansson writes:
>
>
>>Seems that the human-readible parts are printed at a differnet printk level
>>(well, _at_ a level), so they fell off. Not good.
>
>
> My understanding was that printk lines without a level are considered
> to be at KERN_ERR or so. Is that wrong?
>
>
>>Andrew and/or Paulus, see patch below.
>
>
> It really seems strange to be *removing* printk level tags. I'd like
> to nack this until I understand why it will improve things. At the
> very least it needs a big fat comment so some janitor doesn't come
> along and put the tags back in.

He's removing KERN_ALERT ... I guess it could get switched from
KERN_ALERT to KERN_ERR, but ...

Either way, KERN_ALERT seems way too low to me. I object to getting
half the oops, and not the other half ;-)

M.