Re: 2.6.16-rc5-mm1

Ashok Raj
2006-03-01T19:32:09Z

On Wed, Mar 01, 2006 at 10:48:22AM -0800, Andrew Morton wrote:
> > -static unsigned int __devinitdata num_processors;
> > +unsigned int __cpuinitdata num_processors;
>
> We'll need more than that - the compile failed due to a missing declaration.

--
Cheers,
Ashok Raj
- Open Source Technology Center

Need to make this non-static since we need in acpi_unmap_lsapic
shared function in arch/i386/kernel/acpi/boot.c

Signed-off-by: Ashok Raj <ashok.raj@intel.com>
--------------------------------------------------------
arch/i386/kernel/mpparse.c | 2 +-
include/asm-i386/smp.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6.16-rc5-mm1/arch/i386/kernel/mpparse.c
===================================================================
--- linux-2.6.16-rc5-mm1.orig/arch/i386/kernel/mpparse.c
+++ linux-2.6.16-rc5-mm1/arch/i386/kernel/mpparse.c
@@ -75,7 +75,7 @@ unsigned int def_to_bigsmp = 0;
/* Processor that is doing the boot up */
unsigned int boot_cpu_physical_apicid = -1U;
/* Internal processor count */
-static unsigned int __devinitdata num_processors;
+unsigned int __cpuinitdata num_processors;

/* Bitmask of physically existing CPUs */
physid_mask_t phys_cpu_present_map;
Index: linux-2.6.16-rc5-mm1/include/asm-i386/smp.h
===================================================================
--- linux-2.6.16-rc5-mm1.orig/include/asm-i386/smp.h
+++ linux-2.6.16-rc5-mm1/include/asm-i386/smp.h
@@ -92,6 +92,7 @@ static __inline int logical_smp_processo

extern int __cpu_disable(void);
extern void __cpu_die(unsigned int cpu);
+extern unsigned int num_processors;
#endif /* !__ASSEMBLY__ */

#else /* CONFIG_SMP */