Re: [PATCH] Fix powerpc bad_page_fault output (Re: 2.6.16-rc5-mm1)

Paul Mackerras
2006-03-02T05:16:44Z

Martin Bligh writes:

> He's removing KERN_ALERT ... I guess it could get switched from
> KERN_ALERT to KERN_ERR, but ...
>
> Either way, KERN_ALERT seems way too low to me. I object to getting
> half the oops, and not the other half ;-)

KERN_ALERT is two steps higher in priority (lower number) than
KERN_ERR. Why on earth would we see KERN_ERR messages but not
KERN_ALERT messages?

In fact die() should probably be using KERN_EMERG.

Messages without a loglevel are by default logged at KERN_WARNING
level, one step lower in priority than KERN_ERR.

This all sounds to me like there is something wacky going on
somewhere, and we need to get to the bottom of it rather than just
remove printk tags.

Paul.