Re: 2.6.16-rc5-mm1

Ashok Raj
2006-03-01T18:20:18Z

On Wed, Mar 01, 2006 at 03:25:27AM -0800, Andrew Morton wrote:
> Andrew Morton <akpm@osdl.org> wrote:
> >
> > If you have (even more) time you could test
> > http://www.zip.com.au/~akpm/linux/patches/stuff/2.6.16-rc5-mm2-pre1.gz.
>
> err, don't enable CONFIG_ACPI_HOTPLUG_CPU.
>
> Ashok, x86_64 and i386 share a lot of code. Please always perform good
> regression testing against one when developing for the other.
>
> arch/i386/kernel/acpi/boot.c: In function `acpi_unmap_lsapic':
> arch/i386/kernel/acpi/boot.c:583: `num_processors' undeclared (first use in this function)

Sorry,

here is one to make it non-static for i386 as well.

--
Cheers,
Ashok Raj
- Open Source Technology Center

Need to make "num_processors" non-static since we need in acpi_unmap_lsapic
shared function in arch/i386/kernel/acpi/boot.c. Also needs to be __cpuinitdata
now.

Signed-off-by: Ashok Raj <ashok.raj@intel.com>
--------------------------------------------------------
arch/i386/kernel/mpparse.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.16-rc5-mm1/arch/i386/kernel/mpparse.c
===================================================================
--- linux-2.6.16-rc5-mm1.orig/arch/i386/kernel/mpparse.c
+++ linux-2.6.16-rc5-mm1/arch/i386/kernel/mpparse.c
@@ -75,7 +75,7 @@ unsigned int def_to_bigsmp = 0;
/* Processor that is doing the boot up */
unsigned int boot_cpu_physical_apicid = -1U;
/* Internal processor count */
-static unsigned int __devinitdata num_processors;
+unsigned int __cpuinitdata num_processors;

/* Bitmask of physically existing CPUs */
physid_mask_t phys_cpu_present_map;