Re: 2.6.16-rc5-mm1

Andrew Morton
2006-03-01T18:50:04Z

Ashok Raj <ashok.raj@intel.com> wrote:
>
> On Wed, Mar 01, 2006 at 03:25:27AM -0800, Andrew Morton wrote:
> > Andrew Morton <akpm@osdl.org> wrote:
> > >
> > > If you have (even more) time you could test
> > > http://www.zip.com.au/~akpm/linux/patches/stuff/2.6.16-rc5-mm2-pre1.gz.
> >
> > err, don't enable CONFIG_ACPI_HOTPLUG_CPU.
> >
> > Ashok, x86_64 and i386 share a lot of code. Please always perform good
> > regression testing against one when developing for the other.
> >
> > arch/i386/kernel/acpi/boot.c: In function `acpi_unmap_lsapic':
> > arch/i386/kernel/acpi/boot.c:583: `num_processors' undeclared (first use in this function)
>
> ...
>
> Need to make "num_processors" non-static since we need in acpi_unmap_lsapic
> shared function in arch/i386/kernel/acpi/boot.c. Also needs to be __cpuinitdata
> now.
>
> ...
>
> -static unsigned int __devinitdata num_processors;
> +unsigned int __cpuinitdata num_processors;

We'll need more than that - the compile failed due to a missing declaration.