Re: + proc-dont-lock-task_structs-indefinitely-cpuset-fix-2.patch added to -mm tree

Andrew Morton
2006-03-03T06:45:57Z

Paul Jackson <pj@sgi.com> wrote:
>
> Andrew wrote:
> > From: Andrew Morton <akpm@osdl.org>
> >
> > We presently ignore the return values from initcalls. But that can carry
> > useful debugging information. So print it out if it's non-zero.
> >
> > Also make that warning message more friendly by printing the name of the
> > initcall function.
>
> I tried this patch on my sicko kernel, and the following
> additional line came out, as expected:
>
> initcall at 0xa0000001007cc4c0: topology_init+0x0/0x280(): returned with error code -12

Yes, I've just been looking at the output. There are quite a few ENODEV's
of course. But it's pretty obvious what's going on from the name of the
function. It does remind you that you have drivers in vmlinux which aren't
doing anything useful.

We'll see how it goes.