Re: [PATCH 2/2] strndup_user (v3), convert (keyctl)

[Davi Arnaut <davi.arnaut@gmail.com>]

On Wed, 1 Mar 2006 12:50:53 -0800
Andrew Morton <akpm@osdl.org> wrote:

> Davi Arnaut <davi.arnaut@gmail.com> wrote:
> >
> > On Wed, 01 Mar 2006 14:06:20 +0000
> > David Howells <dhowells@redhat.com> wrote:
> > 
> > > Davi Arnaut <davi.arnaut@gmail.com> wrote:
> > > 
> > > > In keyctl_keyring_search() there wasn't a check for type[0] == '.', but your
> > > > mm-patch added one implicitly. Which one is correct ?
> > > 
> > > Ummm... good point. Key types beginning with a dot are special, and userspace
> > > isn't allowed to create them. I'm not sure whether they should be findable or
> > > not, but I'm happy go for not at the moment (so the patch is correct, not the
> > > original).
> > > 
> > > There's another minor problem with your patch:
> > > 
> > > 	warthog>grep -r strndup_user *
> > > 	warthog1>
> > > 
> > > I take it that this isn't in Linus's kernel yet... However, I don't want my
> > > patch to be held up too much since there are some awkward holes that need
> > > fixing. I'm definitely in favour of strndup_user() though.
> > > 
> > > David
> > 
> > Andrew, are you willing to merge for .17 ?
> > 
> 
> Which, strndup_user()?
> 
> I guess so - would need to see it again.  But David's
> keys-deal-properly-with-strnlen_user.patch should go first, since it
> kinda-fixes things.

Ok, I will resend.

> <remembers that macro, shudders>

I think that's ok with David if we drop it and merge mine. It's much simpler.

--
Davi Arnaut