From: Paul Jackson <pj@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: akpm@osdl.org, Simon.Derr@bull.net, linux-kernel@vger.kernel.org,
ebiederm@xmission.com
Subject: Re: [PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c
Date: Thu, 2 Mar 2006 06:23:59 -0800 [thread overview]
Message-ID: <20060302062359.5940ff7f.pj@sgi.com> (raw)
In-Reply-To: <20060302084739.GC21902@infradead.org>
> Seems pointless. This just increases #ifdef churn for no gain.
Take a look at fs/proc/base.c. That's how pretty much all the
other proc hooks are done, with ifdef's around their proc hooks.
ifdef minimization is a good goal, yes.
But uniformity of practice is another good goal.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2006-03-02 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-02 7:08 [PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c Paul Jackson
2006-03-02 8:47 ` Christoph Hellwig
2006-03-02 14:23 ` Paul Jackson [this message]
2006-03-02 16:32 ` Eric W. Biederman
2006-03-02 16:52 ` Paul Jackson
2006-03-02 17:09 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060302062359.5940ff7f.pj@sgi.com \
--to=pj@sgi.com \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox