From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Pierre Ossman <drzeus-list@drzeus.cx>
Cc: Jens Axboe <axboe@suse.de>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: How to map high memory for block io
Date: Thu, 2 Mar 2006 11:45:26 +0000 [thread overview]
Message-ID: <20060302114526.GC14017@flint.arm.linux.org.uk> (raw)
In-Reply-To: <4406C845.8000603@drzeus.cx>
On Thu, Mar 02, 2006 at 11:26:13AM +0100, Pierre Ossman wrote:
> This I know. My beef is the readability of:
>
> if (do_dma)
> *dev->dma_mask = DEVICE_DMA_MASK;
> else
> *dev->dma_mask = 0;
>
> I.e. we use dma_mask even though we don't do DMA.
Not a lot we can do about the readability issue - we end up with code
like that in some layer of the MMC. If it's in mmc_queue, it might be:
u64 limit = BLK_BOUNCE_HIGH;
if (host->caps & MMC_CAP_DMA &&
host->dev->dma_mask && *host->dev->dma_mask)
limit = *host->dev->dma_mask;
which is equally as (un)readable as your code.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-03-02 11:45 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 6:45 How to map high memory for block io Pierre Ossman
2006-01-27 10:26 ` Jens Axboe
2006-01-27 10:33 ` Pierre Ossman
2006-01-27 10:43 ` Jens Axboe
2006-01-27 12:14 ` Pierre Ossman
2006-01-27 12:39 ` Jens Axboe
2006-01-27 13:16 ` Pierre Ossman
2006-01-27 13:48 ` Pierre Ossman
2006-01-27 14:00 ` Jens Axboe
2006-01-27 14:14 ` Pierre Ossman
2006-01-27 18:37 ` Pierre Ossman
2006-01-27 19:43 ` Russell King
2006-01-27 20:04 ` Pierre Ossman
2006-01-27 20:10 ` Jens Axboe
2006-01-27 20:14 ` Russell King
2006-01-27 20:22 ` Jens Axboe
2006-01-27 20:26 ` Russell King
2006-01-27 20:38 ` Pierre Ossman
2006-01-27 21:58 ` Pierre Ossman
2006-01-27 22:54 ` Russell King
2006-01-28 19:17 ` Jens Axboe
2006-01-28 19:32 ` Pierre Ossman
2006-01-29 15:22 ` Jens Axboe
2006-01-30 7:57 ` Pierre Ossman
2006-01-30 8:09 ` Jens Axboe
2006-01-31 18:39 ` Pierre Ossman
2006-03-01 23:29 ` Russell King
2006-03-02 7:21 ` Jens Axboe
2006-03-02 7:26 ` Pierre Ossman
2006-03-02 9:41 ` Russell King
2006-03-02 9:52 ` Pierre Ossman
2006-03-02 10:04 ` Russell King
2006-03-02 10:26 ` Pierre Ossman
2006-03-02 11:45 ` Russell King [this message]
2007-01-30 20:41 ` Pierre Ossman
2006-01-27 20:28 ` Pierre Ossman
2006-01-27 20:12 ` Pierre Ossman
2006-01-27 20:16 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060302114526.GC14017@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=axboe@suse.de \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox