public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Jens Axboe <axboe@suse.de>
Cc: Michael Monnerie <m.monnerie@zmi.at>,
	Jeff Garzik <jgarzik@pobox.com>,
	linux-kernel@vger.kernel.org
Subject: Re: PCI-DMA: Out of IOMMU space on x86-64 (Athlon64x2), with solution
Date: Thu, 2 Mar 2006 14:33:16 +0100	[thread overview]
Message-ID: <200603021433.17235.ak@suse.de> (raw)
In-Reply-To: <20060302131043.GN4329@suse.de>


> - We have in-driver pending stuff, so we can just retry the operation
>   later when some of that completes.
> - We are unlucky enough that someone else holds all the resources, we
>   have nothing to wait for.

I suspect the second is more common - typically the problem seems to happen
when people have multiple devices active that need the IOMMU in parallel.

> The first case is easy, just punt and retry when some of your io
> completes. The last case requires a way to wait on the iommu as you
> describe, which the driver needs to do somewhere safe.

Also where to put the wait queue? The IOMMU code only 
sees the bus devices not the queues and I'm not sure the low level
devices would be the right place to put it because it wouldn't handle
the case of a queue having multiple devices well and in general
would probably violate the layers.

Maybe just using a global one? The situation should be rare anyways.
Would just need a way to detect this case to avoid bouncing the cache lines
of the wait queue in the normal case. Perhaps a simple global counter
would be good enough for that.

e.g. you increase the counter and then the IOMMU code just does a wakeup
on a global waitqueue every time it frees space.

Hrm one problem I guess is that you need to make sure there are no 
races between detection of the low space condition and the increasing
of the counter, but some lazy locking and rechecking might be able 
to cure that.

-Andi

  reply	other threads:[~2006-03-02 13:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-01 23:23 PCI-DMA: Out of IOMMU space on x86-64 (Athlon64x2), with solution Michael Monnerie
2006-03-02  1:03 ` Andi Kleen
2006-03-02  9:59   ` Jens Axboe
2006-03-03  8:16   ` Chris Wedgwood
2006-03-03 11:00     ` Andi Kleen
     [not found] ` <200603021316.38077.ak@suse.de>
     [not found]   ` <4406E226.4050806@pobox.com>
2006-03-02 12:26     ` Andi Kleen
2006-03-02 12:31       ` Jens Axboe
2006-03-02 12:33       ` Jeff Garzik
     [not found]   ` <20060302123033.GL4329@suse.de>
2006-03-02 13:09     ` Andi Kleen
2006-03-02 13:10       ` Jens Axboe
2006-03-02 13:33         ` Andi Kleen [this message]
2006-03-02 13:33           ` Jens Axboe
2006-03-02 13:46             ` Andi Kleen
2006-03-02 13:49               ` Jens Axboe
2006-03-02 13:58                 ` Andi Kleen
2006-03-02 14:14                   ` Jens Axboe
2006-03-02 14:35                     ` Andi Kleen
2006-03-02 14:38                       ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2006-03-03 21:27 Allen Martin
2006-03-03 22:12 ` Andi Kleen
2006-03-03 22:23   ` Jeff Garzik
2006-03-03 22:32     ` Andi Kleen
2006-03-04  6:34     ` Michael Monnerie
     [not found] <5Mq18-1Na-21@gated-at.bofh.it>
     [not found] ` <5MqNc-2Y5-3@gated-at.bofh.it>
     [not found]   ` <5MqX4-39H-21@gated-at.bofh.it>
     [not found]     ` <5MyAS-5zh-5@gated-at.bofh.it>
2006-03-07  0:15       ` Robert Hancock
2006-04-02  7:51         ` Joerg Bashir
2006-04-02  8:00           ` Muli Ben-Yehuda
2006-04-02  8:24             ` Joerg Bashir
2006-04-02 11:16           ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200603021433.17235.ak@suse.de \
    --to=ak@suse.de \
    --cc=axboe@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.monnerie@zmi.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox