public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'Hugh Dickins'" <hugh@veritas.com>
Cc: "'David Gibson'" <david@gibson.dropbear.id.au>,
	"Andrew Morton" <akpm@osdl.org>,
	"William Irwin" <wli@holomorphy.com>,
	<linux-ia64@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: hugepage: Fix hugepage logic in free_pgtables()
Date: Thu, 2 Mar 2006 13:29:50 -0800	[thread overview]
Message-ID: <200603022129.k22LTog14318@unix-os.sc.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0603022002500.23669@goblin.wat.veritas.com>

Hugh Dickins wrote on Thursday, March 02, 2006 12:27 PM
> But the first part, || instead of && in is_hugepage_only_range, looks
> insufficient: the start and end of the range might each fall in a
> non-huge region, but the range still cross a huge region.
> 
> Ah, does RGN_HPAGE nestle up against the TASK_SIZE roof, so any range
> already tested against TASK_SIZE (as get_unmapped_area has) cannot
> cross RGN_HPAGE?  If so, perhaps it deserves a comment there.  And
> if that is so, and can be relied upon, is_hugepage_only_range need
> only be testing REGION_NUMBER(addr+len-1) - but it does seem fragile.

There are many address range check before we hit get_unmapped area.
ia64 can never have a vma range that crosses region boundary.  David
pointed out earlier that shmat and mremap can still slip through the
crack and he has a patch that fixed it. But yes, this patch is making
that assumption (or relying on checks being done properly beforehand).

- Ken


  reply	other threads:[~2006-03-02 21:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-02  4:52 hugepage: Fix hugepage logic in free_pgtables() 'David Gibson'
2006-03-02 18:53 ` Hugh Dickins
2006-03-02 19:42   ` Chen, Kenneth W
2006-03-02 20:27     ` Hugh Dickins
2006-03-02 21:29       ` Chen, Kenneth W [this message]
2006-03-02 23:00         ` 'David Gibson'
2006-03-02 23:14     ` 'David Gibson'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200603022129.k22LTog14318@unix-os.sc.intel.com \
    --to=kenneth.w.chen@intel.com \
    --cc=akpm@osdl.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=hugh@veritas.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox