From: Vojtech Pavlik <vojtech@suse.cz>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Adam Belay <ambx1@neo.rr.com>,
linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@suse.cz>,
Matthieu Castet <castet.matthieu@free.fr>,
Li Shaohua <shaohua.li@intel.com>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 5/9] ns558: adjust pnp_register_driver signature
Date: Fri, 3 Mar 2006 13:55:43 +0100 [thread overview]
Message-ID: <20060303125543.GC11899@suse.cz> (raw)
In-Reply-To: <200603021609.37525.bjorn.helgaas@hp.com>
On Thu, Mar 02, 2006 at 04:09:37PM -0700, Bjorn Helgaas wrote:
> Remove the assumption that pnp_register_driver() returns the number of
> devices claimed.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Wouldn't a diff like
--- a/drivers/input/gameport/ns558.c 2006-03-02 12:40:45.000000000 -0700
+++ b/drivers/input/gameport/ns558.c 2006-03-02 12:43:58.000000000 -0700
@@ -258,7 +256,7 @@
{
int i = 0;
- if (pnp_register_driver(&ns558_pnp_driver) >= 0)
+ if (!pnp_register_driver(&ns558_pnp_driver))
pnp_registered = 1;
/*
be enough? The err variable isn't used anywhere else.
> Index: work-mm4/drivers/input/gameport/ns558.c
> ===================================================================
> --- work-mm4.orig/drivers/input/gameport/ns558.c 2006-03-02 12:40:45.000000000 -0700
> +++ work-mm4/drivers/input/gameport/ns558.c 2006-03-02 12:43:58.000000000 -0700
> @@ -256,9 +256,10 @@
>
> static int __init ns558_init(void)
> {
> - int i = 0;
> + int i = 0, err;
>
> - if (pnp_register_driver(&ns558_pnp_driver) >= 0)
> + err = pnp_register_driver(&ns558_pnp_driver);
> + if (!err)
> pnp_registered = 1;
>
> /*
>
>
--
Vojtech Pavlik
Director SuSE Labs
next prev parent reply other threads:[~2006-03-03 12:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-02 23:01 [PATCH 0/9] PNP: adjust pnp_register_driver signature Bjorn Helgaas
2006-03-02 23:09 ` [PATCH 1/9] parport: " Bjorn Helgaas
2006-03-02 23:09 ` [PATCH 2/9] mpu401: " Bjorn Helgaas
2006-03-02 23:09 ` [PATCH 3/9] cs4236: " Bjorn Helgaas
2006-03-02 23:09 ` [PATCH 4/9] opl3sa2: " Bjorn Helgaas
2006-03-02 23:09 ` [PATCH 5/9] ns558: " Bjorn Helgaas
2006-03-03 12:55 ` Vojtech Pavlik [this message]
2006-03-03 15:58 ` Bjorn Helgaas
2006-03-02 23:09 ` [PATCH 6/9] i8042: " Bjorn Helgaas
2006-03-14 5:31 ` Dmitry Torokhov
2006-03-02 23:09 ` [PATCH 7/9] IRDA: " Bjorn Helgaas
2006-03-02 23:09 ` [PATCH 8/9] cs4232: " Bjorn Helgaas
2006-03-02 23:09 ` [PATCH 9/9] PNP: " Bjorn Helgaas
2006-03-14 6:19 ` [PATCH 0/9] " Adam Belay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060303125543.GC11899@suse.cz \
--to=vojtech@suse.cz \
--cc=akpm@osdl.org \
--cc=ambx1@neo.rr.com \
--cc=bjorn.helgaas@hp.com \
--cc=castet.matthieu@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox